linux-kernel - Re: [PATCH] ARM:kernel: beautify code, using 'static const' instead of 'const static'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 Mar 2013 13:02:59 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	Rob Herring <robherring2@...il.com>
CC:	Russell King - ARM Linux <linux@....linux.org.uk>,
	linus.walleij@...aro.org, marc.zyngier@....com,
	shawn.guo@...aro.org,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM:kernel: beautify code, using 'static const' instead
 of 'const static'

于 2013年03月11日 09:26, Rob Herring 写道:
> On 03/09/2013 07:59 PM, Chen Gang wrote:
>> > 
>> >   better using 'static const' instead of 'const static'
>> > 
>> > Signed-off-by: Chen Gang <gang.chen@...anux.com>
>> > ---
>> >  arch/arm/kernel/smp_twd.c |    2 +-
>> >  1 files changed, 1 insertions(+), 1 deletions(-)
>> > 
>> > diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c
>> > index 3f25650..ef3e499 100644
>> > --- a/arch/arm/kernel/smp_twd.c
>> > +++ b/arch/arm/kernel/smp_twd.c
>> > @@ -362,7 +362,7 @@ int __init twd_local_timer_register(struct twd_local_timer *tlt)
>> >  }
>> >  
>> >  #ifdef CONFIG_OF
>> > -const static struct of_device_id twd_of_match[] __initconst = {
>> > +static const struct of_device_id twd_of_match[] __initconst = {
> This will go away with conversion to use CLKSRC_OF.

  excuse me, I am not quite familiar with ARM, so I do not quite
understand what you said.

  could you describe it with more details ?
  and how about this patch ?
    a. do not need this patch.
    b. or this patch need improving.
    c. or this patch is ok, can be applied.

  thanks.

-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/