lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 Mar 2013 20:31:54 +0100 From: Mirsal Ennaime <mirsal@...sal.fr> To: Greg Kroah-Hartman <greg@...ah.com> Cc: Arve Hjønnevåg <arve@...roid.com>, Brian Swetland <swetland@...gle.com>, devel@...verdev.osuosl.org, kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org, Mirsal Ennaime <mirsal@...sal.fr> Subject: [PATCH 3/4] drivers: android: binder: Remove excessive indentation Remove one level of indentation from the binder proc page release code by using slightly different control semantics. This is a cosmetic patch which removes checkpatch "80-columns" warnings Signed-off-by: Mirsal Ennaime <mirsal@...sal.fr> --- drivers/staging/android/binder.c | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index 49cc573..18a83e2 100644 --- a/drivers/staging/android/binder.c +++ b/drivers/staging/android/binder.c @@ -3002,18 +3002,20 @@ static void binder_deferred_release(struct binder_proc *proc) if (proc->pages) { int i; for (i = 0; i < proc->buffer_size / PAGE_SIZE; i++) { - if (proc->pages[i]) { - void *page_addr = proc->buffer + i * PAGE_SIZE; - binder_debug(BINDER_DEBUG_BUFFER_ALLOC, - "binder_release: %d: page %d at %p not freed\n", - proc->pid, i, - page_addr); - unmap_kernel_range((unsigned long)page_addr, - PAGE_SIZE); - __free_page(proc->pages[i]); - page_count++; - } + if (!proc->pages[i]) + continue; + + void *page_addr = proc->buffer + i * PAGE_SIZE; + binder_debug(BINDER_DEBUG_BUFFER_ALLOC, + "binder_release: %d: page %d at %p not freed\n", + proc->pid, i, + page_addr); + unmap_kernel_range((unsigned long)page_addr, + PAGE_SIZE); + __free_page(proc->pages[i]); + page_count++; } + kfree(proc->pages); vfree(proc->buffer); } -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists