linux-kernel - Re: [PATCH v2] drm/i915: bounds check execbuffer relocation count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jJrszKtqwQxWFT3gbjubn4iRedaZHbyJ6LJRy7EVzbftw@mail.gmail.com>
Date:	Mon, 11 Mar 2013 15:25:59 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Chris Wilson <chris@...is-wilson.co.uk>,
	Kees Cook <keescook@...omium.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	David Airlie <airlied@...ux.ie>,
	dri-devel@...ts.freedesktop.org, Julien Tinnes <jln@...gle.com>,
	marcheu@...omium.org
Subject: Re: [PATCH v2] drm/i915: bounds check execbuffer relocation count

On Mon, Mar 11, 2013 at 3:00 PM, Chris Wilson <chris@...is-wilson.co.uk> wrote:
> On Mon, Mar 11, 2013 at 02:23:29PM -0700, Kees Cook wrote:
>> It is possible to wrap the counter used to allocate the buffer for
>> relocation copies. This could lead to heap writing overflows.
>
> I'd keep the return value as EINVAL so that we can continue to
> distinguish between the user passing garbage and hitting an oom. And
> total_relocs is preferrable to total, which also leads us to think more
> carefully about the error condition. I think the check should be against
> INT_MAX / sizeof(struct reloc_entry) for consistency with our other
> guard against overflows whilst allocating.

I've ended up with this:

        int max_alloc = INT_MAX / sizeof(struct drm_i915_gem_relocation_entry);
...
                /* First check for malicious input causing overflow */
                if (exec[i].relocation_count > max_alloc)
                        return -EINVAL;
                if (exec[i].relocation_count > max_alloc - total_relocs)
                        return -EINVAL;
                total_relocs += exec[i].relocation_count;

And looking at that, I wonder if we should just eliminate the first if entirely?

-Kees

--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/