linux-kernel - Re: [PATCH v2 2/3] drivers: android: binder: Fix code style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Mar 2013 16:57:48 -0700
From:	Arve Hjønnevåg <arve@...roid.com>
To:	Mirsal Ennaime <mirsal@...sal.fr>
Cc:	Greg Kroah-Hartman <greg@...ah.com>,
	Brian Swetland <swetland@...gle.com>,
	devel@...verdev.osuosl.org, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Dan Carpenter <dan.carpenter@...cle.com>,
	Joe Perches <joe@...ches.com>
Subject: Re: [PATCH v2 2/3] drivers: android: binder: Fix code style

On Mon, Mar 11, 2013 at 4:26 PM, Mirsal Ennaime <mirsal@...sal.fr> wrote:
>  * Use tabs
>  * Remove a few "80-columns" checkpatch warnings
>  * Separate code paths with empty lines for readability
>
> Signed-off-by: Mirsal Ennaime <mirsal@...sal.fr>
> ---
>  drivers/staging/android/binder.c |   42 +++++++++++++++++++++++++-------------
>  1 file changed, 28 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
> index 43f823d..4652cd8 100644
> --- a/drivers/staging/android/binder.c
> +++ b/drivers/staging/android/binder.c
> @@ -2927,57 +2927,69 @@ static void binder_deferred_release(struct binder_proc *proc)
>  {
>         struct binder_transaction *t;
>         struct rb_node *n;
> -       int threads, nodes, incoming_refs, outgoing_refs, buffers, active_transactions, page_count;
> +       int threads, nodes, incoming_refs, outgoing_refs, buffers,
> +               active_transactions, page_count;
>
>         BUG_ON(proc->vma);
>         BUG_ON(proc->files);
>
>         hlist_del(&proc->proc_node);
> +
>         if (binder_context_mgr_node && binder_context_mgr_node->proc == proc) {
>                 binder_debug(BINDER_DEBUG_DEAD_BINDER,
> -                            "binder_release: %d context_mgr_node gone\n",
> -                            proc->pid);
> +                       "binder_release: %d context_mgr_node gone\n",
> +                       proc->pid);

I don't like this change (and the others like it). If is not uncommon
the align arguments on that don't fit the first line with the
arguments on the first line, so why change it here?

-- 
Arve Hjønnevåg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/