linux-kernel - Re: [PATCH 1/2] PCI: define macro for marvell vendor ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJtEV7YDNGq-t1W2Q4=mBobKGATz14hqkamauL=5KqZ728U9wg@mail.gmail.com>
Date:	Tue, 12 Mar 2013 13:23:02 +0800
From:	Andrew Cooks <acooks@...il.com>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	yxlraid@...il.com,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Xiangliang Yu <yuxiangl@...vell.com>
Subject: Re: [PATCH 1/2] PCI: define macro for marvell vendor ID

On Fri, Mar 8, 2013 at 12:24 AM, Bjorn Helgaas <bhelgaas@...gle.com> wrote:
> On Thu, Mar 7, 2013 at 7:28 AM,  <yxlraid@...il.com> wrote:
>> From: Xiangliang Yu <yuxiangl@...vell.com>
>>
>> Define PCI_VENDOR_MARVELL_ID_EXT macro for 0x1b4b vendor ID
>
> "PCI_VENDOR_MARVELL_ID_EXT" is not actually the symbol you defined below.
>
> Per the comment at the top of pci_ids.h, we don't add things here
> unless they are shared between multiple drivers.
>
> That said, the 0x1b4b vendor ID is used in mv_init.c, mvumi.h,
> mvumi.c, and ahci.c.  If you want to unify all those so they all use
> same symbol, and define that symbol here in pci_ids.h, that would be
> fine with me.
>

This symbol will also be useful for the quirk that creates iommu
context entries for Marvell devices that use incorrect dma source
tags. I'll update and resend that patch when this change has been
merged.

Thanks
Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/