linux-kernel - Re: Fix memory leak in cpufreq stats.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130312121458.GC3222@hercules>
Date:	Tue, 12 Mar 2013 12:14:58 +0000
From:	Luis Henriques <luis.henriques@...onical.com>
To:	Colin Cross <ccross@...gle.com>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	"Tu, Xiaobing" <xiaobing.tu@...el.com>,
	"davej@...hat.com" <davej@...hat.com>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"mingo@...e.hu" <mingo@...e.hu>,
	"rusty@...tcorp.com.au" <rusty@...tcorp.com.au>,
	"a.p.zijlstra@...llo.nl" <a.p.zijlstra@...llo.nl>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"rostedt@...dmis.org" <rostedt@...dmis.org>,
	"Tang, Guifang" <guifang.tang@...el.com>, stable@...r.kernel.org
Subject: Re: Fix memory leak in cpufreq stats.

On Mon, Mar 11, 2013 at 06:23:27PM -0700, Colin Cross wrote:
> On Mon, Oct 15, 2012 at 1:30 PM, Rafael J. Wysocki <rjw@...k.pl> wrote:
> > On Monday 15 of October 2012 02:48:28 Tu, Xiaobing wrote:
> >>
> >> Fix memory leak in cpufreq stats.
> >>
> >> When system enter sleep, non-boot CPUs will be disable.
> >> Cpufreq stats sysfs is created when the CPU is up, but it is not freed when
> >> the CPU going down. This will cause memory leak.
> >> signed-off-by: xiaobing tu <xiaobing.tu@...el.com>
> >> signed-off-by: guifang tang <guifang.tang@...el.com>
> >
> > I will push this patch for v3.7 in the -rc3 time frame if no one objects.
> >
> > Thanks,
> > Rafael
> >
> >
> >> diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c
> >> index b40ee14..3998316 100644
> >> --- a/drivers/cpufreq/cpufreq_stats.c
> >> +++ b/drivers/cpufreq/cpufreq_stats.c
> >> @@ -328,6 +328,7 @@ static int __cpuinit cpufreq_stat_cpu_callback(struct notifier_block *nfb,
> >>                 cpufreq_update_policy(cpu);
> >>                 break;
> >>         case CPU_DOWN_PREPARE:
> >> +       case CPU_DOWN_PREPARE_FROZEN:
> >>                 cpufreq_stats_free_sysfs(cpu);
> >>                 break;
> >>         case CPU_DEAD:
> >>
> >> Br
> >> XiaoBing Tu
> >> PSI@...tem Integration Shanghai
> 
> This patch, commited as e37736777254ce1abc85493a5cacbefe5983b896 since
> v3.7, should also have gone to stable.  It should apply all the way
> back to 3.0.

Thanks, I'm queuing it for the 3.5 kernel.

Cheers,
--
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/