[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130312121613.GT4977@n2100.arm.linux.org.uk>
Date: Tue, 12 Mar 2013 12:16:13 +0000
From: Russell King - ARM Linux <linux@....linux.org.uk>
To: Danny Huang <dahuang@...dia.com>
Cc: swarren@...dotorg.org, hdoyu@...dia.com, olof@...om.net,
gregkh@...uxfoundation.org, arnd@...db.de, josephl@...dia.com,
pdeschrijver@...dia.com, pgaikwad@...dia.com,
linux-arm-kernel@...ts.infradead.org, linux-tegra@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ARM: tegra: expose chip ID and revision
On Tue, Mar 12, 2013 at 08:01:07PM +0800, Danny Huang wrote:
> + if (IS_ERR_OR_NULL(soc_dev))
Sigh. NAK. Fur cryin out loud! Use the IS_ERR() version.
And you don't need the following "return;" statement - that's already
implied at the closing brace of a function.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists