linux-kernel - Re: [PATCH 1/2] cpufreq: cpufreq-cpu0: support for clock which are not in DT yet.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <513F3A88.5060903@ti.com>
Date:	Tue, 12 Mar 2013 15:24:08 +0100
From:	Benoit Cousson <b-cousson@...com>
To:	Santosh Shilimkar <santosh.shilimkar@...com>,
	Nishanth Menon <nm@...com>
CC:	cpufreq <cpufreq@...r.kernel.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Shawn Guo <shawn.guo@...aro.org>,
	<linux-kernel@...r.kernel.org>, <linux-pm@...r.kernel.org>,
	<linux-omap@...r.kernel.org>
Subject: Re: [PATCH 1/2] cpufreq: cpufreq-cpu0: support for clock which are
 not in DT yet.

Hi Guys,

On 03/12/2013 06:03 AM, Santosh Shilimkar wrote:
> On Tuesday 12 March 2013 04:35 AM, Nishanth Menon wrote:
>> On certain SoCs like variants of OMAP, the clock conversion to DT
>> is not complete. In short, the ability to:
>> cpus {
>>     cpu@0 {
>> 	clocks = <&cpuclk 0>;
>>     };
>>  };
>> is not possible. However, the clock node is registered.
>> Allow for clk names to be provided as string so as to be used when needed.
>> Example (for OMAP3630):
>> cpus {
>>     cpu@0 {
>> 	clock-name = "cpufreq_ck";
>>     };
>>  };
>>
>> Cc: "Rafael J. Wysocki" <rjw@...k.pl>
>> Cc: Santosh Shilimkar <santosh.shilimkar@...com>
>> Cc: Shawn Guo <shawn.guo@...aro.org>
>> Cc: linux-kernel@...r.kernel.org
>> Cc: cpufreq@...r.kernel.org
>> Cc: linux-pm@...r.kernel.org
>> Cc: linux-omap@...r.kernel.org
>>
>> Signed-off-by: Nishanth Menon <nm@...com>
>> ---
> Seems a reasonable to me.

No, it is not...

You cannot add a temp binding just because the OMAP support is not
there, since the real binding already exist.

You need to register properly a clock provider to be able to reference
it.
If you do need a hacky temp code you could do it in OMAP code but not in
the binding.


Regards,
Benoit
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/