linux-kernel - Re: [PATCH 11/12] USB: ehci-omap: Try to get PHY even if not in PHY mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1303121155540.2153-100000@iolanthe.rowland.org>
Date:	Tue, 12 Mar 2013 11:57:56 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Roger Quadros <rogerq@...com>, Felipe Balbi <balbi@...com>
cc:	gregkh@...uxfoundation.org, <b-cousson@...com>,
	<mark.rutland@....com>,
	Kernel development list <linux-kernel@...r.kernel.org>,
	USB list <linux-usb@...r.kernel.org>,
	<linux-omap@...r.kernel.org>, <devicetree-discuss@...ts.ozlabs.org>
Subject: Re: [PATCH 11/12] USB: ehci-omap: Try to get PHY even if not in PHY
 mode

On Tue, 12 Mar 2013, Roger Quadros wrote:

> Even when not in PHY mode, the USB device on the port (e.g. HUB)
> might need resources like RESET which can be modelled as a PHY
> device. So try to get the PHY device in any case.
> 
> Signed-off-by: Roger Quadros <rogerq@...com>
> CC: Alan Stern <stern@...land.harvard.edu>

Acked-by: Alan Stern <stern@...land.harvard.edu>

>  		/* get the PHY device */
>  		if (dev->of_node)
>  			phy = devm_usb_get_phy_by_phandle(dev, "phys", i);
>  		else
>  			phy = devm_usb_get_phy_dev(dev, i);
>  		if (IS_ERR(phy) || !phy) {
> +			/* Don't bail out if PHY is not absolutely necessary */
> +			if (pdata->port_mode[i] != OMAP_EHCI_PORT_MODE_PHY)
> +				continue;
> +
>  			ret = IS_ERR(phy) ? PTR_ERR(phy) : -ENODEV;
>  			dev_err(dev, "Can't get PHY device for port %d: %d\n",
>  					i, ret);

Felipe, this is a strange interface.  Why do we sometimes get an 
error-pointer and sometimes get just NULL?  Why not always an 
error-pointer?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/