linux-kernel - Re: [PATCH 3/3] leds: lm355x, lm3642: support Camera LED triggers for flash/torch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 Mar 2013 11:11:57 -0700
From:	Bryan Wu <cooloney@...il.com>
To:	"Kim, Milo" <Milo.Kim@...com>
Cc:	"linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Jeong, Daniel" <Daniel.Jeong@...com>
Subject: Re: [PATCH 3/3] leds: lm355x, lm3642: support Camera LED triggers for flash/torch

On Wed, Feb 20, 2013 at 12:36 AM, Kim, Milo <Milo.Kim@...com> wrote:
> LM355x and LM3642 support flash and torch functionality.
>
>  (Camera driver)          (LED trigger for camera)       (LED driver)
>  Turn on the flash  ...>  ledtrig_flash_ctrl(true) ...>  LM355x or LM3642
>                                                          brightness ctrl
>                                                        <actual driving here>
>
> Flash/torch LEDs are controlled by other driver using LED camera trigger
> APIs, ledtrig_flash_ctrl()/ledtrig_torch_ctrl().
> Then, actual device control is activated by each LED driver such like
> LM355x or LM3642.
>

Looks good to me, I will merge this after you update PATCH 2/3.

Thanks,
-Bryan

> Signed-off-by: Milo(Woogyom) Kim <milo.kim@...com>
> ---
>  drivers/leds/leds-lm355x.c |    2 ++
>  drivers/leds/leds-lm3642.c |    2 ++
>  2 files changed, 4 insertions(+)
>
> diff --git a/drivers/leds/leds-lm355x.c b/drivers/leds/leds-lm355x.c
> index 4117235..d81a8e7 100644
> --- a/drivers/leds/leds-lm355x.c
> +++ b/drivers/leds/leds-lm355x.c
> @@ -477,6 +477,7 @@ static int lm355x_probe(struct i2c_client *client,
>         chip->cdev_flash.name = "flash";
>         chip->cdev_flash.max_brightness = 16;
>         chip->cdev_flash.brightness_set = lm355x_strobe_brightness_set;
> +       chip->cdev_flash.default_trigger = "flash";
>         err = led_classdev_register((struct device *)
>                                     &client->dev, &chip->cdev_flash);
>         if (err < 0)
> @@ -486,6 +487,7 @@ static int lm355x_probe(struct i2c_client *client,
>         chip->cdev_torch.name = "torch";
>         chip->cdev_torch.max_brightness = 8;
>         chip->cdev_torch.brightness_set = lm355x_torch_brightness_set;
> +       chip->cdev_torch.default_trigger = "torch";
>         err = led_classdev_register((struct device *)
>                                     &client->dev, &chip->cdev_torch);
>         if (err < 0)
> diff --git a/drivers/leds/leds-lm3642.c b/drivers/leds/leds-lm3642.c
> index 9f428d9..f361bbe 100644
> --- a/drivers/leds/leds-lm3642.c
> +++ b/drivers/leds/leds-lm3642.c
> @@ -363,6 +363,7 @@ static int lm3642_probe(struct i2c_client *client,
>         chip->cdev_flash.name = "flash";
>         chip->cdev_flash.max_brightness = 16;
>         chip->cdev_flash.brightness_set = lm3642_strobe_brightness_set;
> +       chip->cdev_flash.default_trigger = "flash";
>         err = led_classdev_register((struct device *)
>                                     &client->dev, &chip->cdev_flash);
>         if (err < 0) {
> @@ -380,6 +381,7 @@ static int lm3642_probe(struct i2c_client *client,
>         chip->cdev_torch.name = "torch";
>         chip->cdev_torch.max_brightness = 8;
>         chip->cdev_torch.brightness_set = lm3642_torch_brightness_set;
> +       chip->cdev_torch.default_trigger = "torch";
>         err = led_classdev_register((struct device *)
>                                     &client->dev, &chip->cdev_torch);
>         if (err < 0) {
> --
> 1.7.9.5
>
>
> Best Regards,
> Milo
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/