linux-kernel - Re: [PATCH] efivars: allow efi pstore variable when validate filename

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1363057579.13754.46.camel@linux-s257.site>
Date:	Tue, 12 Mar 2013 11:06:19 +0800
From:	joeyli <jlee@...e.com>
To:	matt.fleming@...el.com
Cc:	linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Seiji Aguchi <seiji.aguchi@....com>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Lingzhu Xiang <lxiang@...hat.com>
Subject: Re: [PATCH] efivars: allow efi pstore variable when validate
 filename

Hi Matt, 

Sorry for I didn't aware your 123abd76edf patch fixed issue.
Please ignore my patch.


Thanks a lot!
Joey Lee

於 二，2013-03-12 於 03:00 +0800，Lee, Chun-Yi 提到：
> We mount efivarfs fail after pstore generated 'dump-type*' variables and
> reboot.
> 
> This issue introduced by commit 47f531e8ba3bc3901a0c493f4252826c41dea1a1
> (efivarfs: Validate filenames much more aggressively)
> 
> The pstore variable is 'dump-type*-*-*-*-GUID'style, it could not pass
> the "GUID should be right after the first '-'" check. This patch allow
> the variable name that has 'dump-type' pass the name check.
> 
> Cc: Matt Fleming <matt.fleming@...el.com>
> Cc: Seiji Aguchi <seiji.aguchi@....com>
> Cc: Matthew Garrett <mjg59@...f.ucam.org>
> Cc: Al Viro <viro@...iv.linux.org.uk>
> Cc: Lingzhu Xiang <lxiang@...hat.com>
> Signed-off-by: Lee, Chun-Yi <jlee@...e.com>
> ---
>  drivers/firmware/efivars.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
> index 3edade0..ab07f7f 100644
> --- a/drivers/firmware/efivars.c
> +++ b/drivers/firmware/efivars.c
> @@ -930,7 +930,7 @@ static bool efivarfs_valid_name(const char *str, int len)
>  		return false;
>  
>  	/* GUID should be right after the first '-' */
> -	if (s - 1 != strchr(str, '-'))
> +	if (s - 1 != strchr(str, '-') && !strstarts(str, "dump-type"))
>  		return false;
>  
>  	/*


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/