lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 12 Mar 2013 15:10:30 -0700 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> Cc: Jan Beulich <JBeulich@...e.com>, Paul Bolle <pebolle@...cali.nl>, Ian Campbell <ian.campbell@...rix.com>, Ben Hutchings <ben@...adent.org.uk>, linux-kernel@...r.kernel.org, stable@...r.kernel.org Subject: Re: [ 34/77] xen/blkback: Dont trust the handle from the frontend. On Mon, Mar 04, 2013 at 10:02:46AM -0500, Konrad Rzeszutek Wilk wrote: > On Mon, Mar 04, 2013 at 09:14:47AM +0000, Jan Beulich wrote: > > >>> On 04.03.13 at 10:11, Paul Bolle <pebolle@...cali.nl> wrote: > > > On Mon, 2013-03-04 at 07:55 +0000, Jan Beulich wrote: > > >> >>> On 03.03.13 at 11:20, Paul Bolle <pebolle@...cali.nl> wrote: > > >> For one, a fix for the (indeed valid) compiler warning has been in > > >> Konrad's tree for several days > > >> > > > (http://git.kernel.org/cgit/linux/kernel/git/konrad/xen.git/commit/drivers/bl > > > ock/xen-blkback/blkback.c?id=a72d9002f80bffd7e4c7d60e5a9caa0cddffe894). > > > > > > Thanks. (For the record: that commit is titled "xen/xen-blkback: > > > preq.dev is used without initialized".) > > > > > >> And second, there's nothing really being fixed with the patch in > > >> question here. The title is kind of misleading, as the handle > > >> coming from the frontend is - without said patch - in the worst > > >> case being used for the very message that triggered the > > >> compiler warning. Nothing else is affected, the code just gave > > >> the impression that the handle was used. > > Which it actually is not, unless somebody compiles the kernel > with #define DEBUG 1 > at the top of the file. > > > >> > > >> IOW I don't see why this got proposed for stable at all. > > > > > > So, you suggest to just drop this patch for v3.8.3, don't you? > > > > I do, yes. But I'd suggest to get Konrad to agree. > > Yes. Lets drop it. Now reverted, thanks. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists