lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 12 Mar 2013 15:32:15 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	linux-kernel@...r.kernel.org
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	stable@...r.kernel.org, Simon Baatz <gmbnomis@...il.com>,
	Jason Cooper <jason@...edaemon.net>
Subject: [ 090/100] ARM: kirkwood: of_serial: fix clock gating by removing clock-frequency

3.8-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Jason Cooper <jason@...edaemon.net>

commit 93fff4ce19f9978cc1c59db42760717477939249 upstream.

When DT support for kirkwood was first introduced, there was no clock
infrastructure.  As a result, we had to manually pass the
clock-frequency to the driver from the device node.

Unfortunately, on kirkwood, with minimal config or all module configs,
clock-frequency breaks booting because of_serial doesn't consume the
gate_clk when clock-frequency is defined.

The end result on kirkwood is that runit gets gated, and then the boot
fails when the kernel tries to write to the serial port.

Fix the issue by removing the clock-frequency parameter from all
kirkwood dts files.

Booted on dreamplug without earlyprintk and successfully logged in via
ttyS0.

Reported-by: Simon Baatz <gmbnomis@...il.com>
Tested-by: Simon Baatz <gmbnomis@...il.com>
Signed-off-by: Jason Cooper <jason@...edaemon.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

---
 arch/arm/boot/dts/kirkwood-dns320.dts         |    2 --
 arch/arm/boot/dts/kirkwood-dns325.dts         |    1 -
 arch/arm/boot/dts/kirkwood-dockstar.dts       |    1 -
 arch/arm/boot/dts/kirkwood-dreamplug.dts      |    1 -
 arch/arm/boot/dts/kirkwood-goflexnet.dts      |    1 -
 arch/arm/boot/dts/kirkwood-ib62x0.dts         |    1 -
 arch/arm/boot/dts/kirkwood-iconnect.dts       |    1 -
 arch/arm/boot/dts/kirkwood-iomega_ix2_200.dts |    1 -
 arch/arm/boot/dts/kirkwood-km_kirkwood.dts    |    1 -
 arch/arm/boot/dts/kirkwood-lschlv2.dts        |    1 -
 arch/arm/boot/dts/kirkwood-lsxhl.dts          |    1 -
 arch/arm/boot/dts/kirkwood-mplcec4.dts        |    1 -
 arch/arm/boot/dts/kirkwood-ns2-common.dtsi    |    1 -
 arch/arm/boot/dts/kirkwood-nsa310.dts         |    1 -
 arch/arm/boot/dts/kirkwood-openblocks_a6.dts  |    2 --
 arch/arm/boot/dts/kirkwood-topkick.dts        |    1 -
 arch/arm/boot/dts/kirkwood.dtsi               |    2 --
 17 files changed, 20 deletions(-)

--- a/arch/arm/boot/dts/kirkwood-dns320.dts
+++ b/arch/arm/boot/dts/kirkwood-dns320.dts
@@ -42,12 +42,10 @@
 
 	ocp@...00000 {
 		serial@...00 {
-			clock-frequency = <166666667>;
 			status = "okay";
 		};
 
 		serial@...00 {
-			clock-frequency = <166666667>;
 			status = "okay";
 		};
 	};
--- a/arch/arm/boot/dts/kirkwood-dns325.dts
+++ b/arch/arm/boot/dts/kirkwood-dns325.dts
@@ -50,7 +50,6 @@
 			};
 		};
 		serial@...00 {
-			clock-frequency = <200000000>;
 			status = "okay";
 		};
 	};
--- a/arch/arm/boot/dts/kirkwood-dockstar.dts
+++ b/arch/arm/boot/dts/kirkwood-dockstar.dts
@@ -37,7 +37,6 @@
 			};
 		};
 		serial@...00 {
-			clock-frequency = <200000000>;
 			status = "ok";
 		};
 
--- a/arch/arm/boot/dts/kirkwood-dreamplug.dts
+++ b/arch/arm/boot/dts/kirkwood-dreamplug.dts
@@ -38,7 +38,6 @@
 			};
 		};
 		serial@...00 {
-			clock-frequency = <200000000>;
 			status = "ok";
 		};
 
--- a/arch/arm/boot/dts/kirkwood-goflexnet.dts
+++ b/arch/arm/boot/dts/kirkwood-goflexnet.dts
@@ -73,7 +73,6 @@
 			};
 		};
 		serial@...00 {
-			clock-frequency = <200000000>;
 			status = "ok";
 		};
 
--- a/arch/arm/boot/dts/kirkwood-ib62x0.dts
+++ b/arch/arm/boot/dts/kirkwood-ib62x0.dts
@@ -51,7 +51,6 @@
 			};
 		};
 		serial@...00 {
-			clock-frequency = <200000000>;
 			status = "okay";
 		};
 
--- a/arch/arm/boot/dts/kirkwood-iconnect.dts
+++ b/arch/arm/boot/dts/kirkwood-iconnect.dts
@@ -78,7 +78,6 @@
 			};
 		};
 		serial@...00 {
-			clock-frequency = <200000000>;
 			status = "ok";
 		};
 
--- a/arch/arm/boot/dts/kirkwood-iomega_ix2_200.dts
+++ b/arch/arm/boot/dts/kirkwood-iomega_ix2_200.dts
@@ -115,7 +115,6 @@
 		};
 
 		serial@...00 {
-			clock-frequency = <200000000>;
 			status = "ok";
 		};
 
--- a/arch/arm/boot/dts/kirkwood-km_kirkwood.dts
+++ b/arch/arm/boot/dts/kirkwood-km_kirkwood.dts
@@ -34,7 +34,6 @@
 		};
 
 		serial@...00 {
-			clock-frequency = <200000000>;
 			status = "ok";
 		};
 
--- a/arch/arm/boot/dts/kirkwood-lschlv2.dts
+++ b/arch/arm/boot/dts/kirkwood-lschlv2.dts
@@ -13,7 +13,6 @@
 
 	ocp@...00000 {
 		serial@...00 {
-			clock-frequency = <166666667>;
 			status = "okay";
 		};
 	};
--- a/arch/arm/boot/dts/kirkwood-lsxhl.dts
+++ b/arch/arm/boot/dts/kirkwood-lsxhl.dts
@@ -13,7 +13,6 @@
 
 	ocp@...00000 {
 		serial@...00 {
-			clock-frequency = <200000000>;
 			status = "okay";
 		};
 	};
--- a/arch/arm/boot/dts/kirkwood-mplcec4.dts
+++ b/arch/arm/boot/dts/kirkwood-mplcec4.dts
@@ -91,7 +91,6 @@
                 };
 
                 serial@...00 {
-                        clock-frequency = <200000000>;
                         status = "ok";
                 };
 
--- a/arch/arm/boot/dts/kirkwood-ns2-common.dtsi
+++ b/arch/arm/boot/dts/kirkwood-ns2-common.dtsi
@@ -23,7 +23,6 @@
 		};
 
 		serial@...00 {
-			clock-frequency = <166666667>;
 			status = "okay";
 		};
 
--- a/arch/arm/boot/dts/kirkwood-nsa310.dts
+++ b/arch/arm/boot/dts/kirkwood-nsa310.dts
@@ -18,7 +18,6 @@
 	ocp@...00000 {
 
 		serial@...00 {
-			clock-frequency = <200000000>;
 			status = "ok";
 		};
 
--- a/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
+++ b/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
@@ -18,12 +18,10 @@
 
 	ocp@...00000 {
 		serial@...00 {
-			clock-frequency = <200000000>;
 			status = "ok";
 		};
 
 		serial@...00 {
-			clock-frequency = <200000000>;
 			status = "ok";
 		};
 
--- a/arch/arm/boot/dts/kirkwood-topkick.dts
+++ b/arch/arm/boot/dts/kirkwood-topkick.dts
@@ -17,7 +17,6 @@
 
 	ocp@...00000 {
 		serial@...00 {
-			clock-frequency = <200000000>;
 			status = "ok";
 		};
 
--- a/arch/arm/boot/dts/kirkwood.dtsi
+++ b/arch/arm/boot/dts/kirkwood.dtsi
@@ -59,7 +59,6 @@
 			reg-shift = <2>;
 			interrupts = <33>;
 			clocks = <&gate_clk 7>;
-			/* set clock-frequency in board dts */
 			status = "disabled";
 		};
 
@@ -69,7 +68,6 @@
 			reg-shift = <2>;
 			interrupts = <34>;
 			clocks = <&gate_clk 7>;
-			/* set clock-frequency in board dts */
 			status = "disabled";
 		};
 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists