[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20130313083720.GD21994@zurbaran>
Date: Wed, 13 Mar 2013 09:37:20 +0100
From: Samuel Ortiz <sameo@...ux.intel.com>
To: Laxman Dewangan <ldewangan@...dia.com>
Cc: gg@...mlogic.co.uk, broonie@...nsource.wolfsonmicro.com,
linux-kernel@...r.kernel.org, swarren@...dia.com,
ian@...mlogic.co.uk
Subject: Re: [PATCH V2] mfd: palmas: provide irq flags through DT/platform
data
Hi Laxman,
On Fri, Mar 01, 2013 at 08:13:46PM +0530, Laxman Dewangan wrote:
> Currently driver sets the irq type to IRQF_TRIGGER_LOW which is
> causing interrupt registration failure in ARM based SoCs as:
> [ 0.208479] genirq: Setting trigger mode 8 for irq 118 failed (gic_set_type+0x0/0xf0)
> [ 0.208513] dummy 0-0059: Failed to request IRQ 118: -22
>
> Provide the irq flags through platform data if device is registered
> through board file or get the irq type from DT node property in place
> of hardcoding the irq flag in driver to support multiple platforms.
>
> Also configure the device to generate the interrupt signal according to
> flag type.
>
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
> ---
> Changes from V1:
> - Use palmas_update_bits() for rea/modiy/write.
>
> drivers/mfd/palmas.c | 36 +++++++++++++++++++++++++++++++++---
> include/linux/mfd/palmas.h | 1 +
> 2 files changed, 34 insertions(+), 3 deletions(-)
Patch applied to my mfd-fixes tree now.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists