linux-kernel - Re: [PATCH] usb: dwc3: Set DWC3 context's mode based on selected mode.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 Mar 2013 14:42:22 +0530
From:	Vivek Gautam <gautamvivek1987@...il.com>
To:	Felipe Balbi <balbi@...com>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	gregkh@...uxfoundation.org, Vivek Gautam <gautam.vivek@...sung.com>
Subject: Re: [PATCH] usb: dwc3: Set DWC3 context's mode based on selected mode.

Hi Balbi,


On Sat, Mar 2, 2013 at 6:55 PM, Vivek Gautam <gautam.vivek@...sung.com> wrote:
> Now that machines may select the mode of working of DWC3 (HOST only,
> GADGET only or DUAL_ROLE), lets set DWC3 mode based on that
> rather than fixing it to whatever DWC3 hardware says.
> This way we can skip initializing Gadget/Host in case
> we are using Host-only/Gadget-only mode respectively.
>

Hope this patch if fine, and mainlinable ?

> Signed-off-by: Vivek Gautam <gautam.vivek@...sung.com>
> ---
>
> Changes from RFC patch "usb: dwc3: Set GCTL.PrtCapDir based on selected mode"
>  - Setting the mode in dwc3 context structure based on
>    selected mode in machine, rather than programming PrtCapDir
>
>  drivers/usb/dwc3/core.c |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 79f335f..be0672f 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -478,7 +478,12 @@ static int dwc3_probe(struct platform_device *pdev)
>                 goto err1;
>         }
>
> -       mode = DWC3_MODE(dwc->hwparams.hwparams0);
> +       if (IS_ENABLED(CONFIG_USB_DWC3_HOST))
> +               mode = DWC3_MODE_HOST;
> +       else if (IS_ENABLED(CONFIG_USB_DWC3_GADGET))
> +               mode = DWC3_MODE_DEVICE;
> +       else
> +               mode = DWC3_MODE_DRD;
>
>         switch (mode) {
>         case DWC3_MODE_DEVICE:
> --
> 1.7.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
Thanks & Regards
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/