linux-kernel - Re: [PATCH -mmotm] scsi: fix the wrong position of the comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAC5umyhija4=87uQ_Aom7Ypj7DysFSLR21k3sZTVux+fvxMLJw@mail.gmail.com>
Date:	Wed, 13 Mar 2013 21:38:04 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	Valdis Kletnieks <Valdis.Kletnieks@...edu>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	Andrew Vasquez <andrew.vasquez@...gic.com>
Subject: Re: [PATCH -mmotm] scsi: fix the wrong position of the comment

2013/3/12  <Valdis.Kletnieks@...edu>:
> On Sun, 10 Mar 2013 17:09:50 +0900, Akinobu Mita said:
>> This fixes the wrong position of the comment introduced by
>> scsi-rename-random32-to-prandom_u32.patch in the -mm tree.
>>
>> Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>
>> Cc: "James E.J. Bottomley" <JBottomley@...allels.com>
>> Cc: Andrew Vasquez <andrew.vasquez@...gic.com>
>> ---
>>  drivers/scsi/qla2xxx/qla_attr.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c
>> index 04bf7b8..e44d47e 100644
>> --- a/drivers/scsi/qla2xxx/qla_attr.c
>> +++ b/drivers/scsi/qla2xxx/qla_attr.c
>> @@ -1939,13 +1939,13 @@ qla24xx_vport_delete(struct fc_vport *fc_vport)
>>       }
>>
>>       /* No pending activities shall be there on the vha now */
>> -     if (ql2xextended_error_logging & ql_dbg_user)
>> -             msleep(prandom_u32() % 10);
>> +     if (ql2xextended_error_logging & ql_dbg_user) {
>>               /*
>>                * Just to see if something falls on the net we have placed
>>                * below
>>                */
>> -
>> +             msleep(prandom_u32() % 10);
>> +     }
>>       BUG_ON(atomic_read(&vha->vref_count));
>
> As others have noted, the msleep is potentially a crock.  However,
> this particular patch is also incorrect - the *real* problem is
> that the 4 line comment connected to the BUG_ON is mis-indented.

In the original code (quoted below), the comment actually connected
to the msleep(), but the word "below" in the comment points to BUG_ON.
So the comment should also be updated in this patch...

        /* No pending activities shall be there on the vha now */
        if (ql2xextended_error_logging & ql_dbg_user)
                msleep(random32()%10);  /* Just to see if something falls on
                                        * the net we have placed below */

        BUG_ON(atomic_read(&vha->vref_count));
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/