linux-kernel - Re: [PATCH] USB: ehci-s5p: Fix phy reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1303131028140.1705-100000@iolanthe.rowland.org>
Date:	Wed, 13 Mar 2013 10:29:25 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Alexander Graf <agraf@...e.de>
cc:	linux-kernel@...r.kernel.org, <linux-usb@...r.kernel.org>,
	<linux-samsung-soc@...r.kernel.org>, <dmueller@...e.de>,
	Vivek Gautam <gautam.vivek@...sung.com>,
	Jingoo Han <jg1.han@...sung.com>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] USB: ehci-s5p: Fix phy reset

On Wed, 13 Mar 2013, Alexander Graf wrote:

> On my Exynos 5 based Arndale system, I need to pull the reset line down
> and then let it go up again to actually perform a reset. Without that
> reset, I can't find any USB hubs on my bus, rendering the USB controller
> useless.
> 
> So this patch implements the above logic, making EHCI and OHCI work on
> Arndale systems for me.
> 
> Signed-off-by: Alexander Graf <agraf@...e.de>
> CC: Vivek Gautam <gautam.vivek@...sung.com>
> CC: Jingoo Han <jg1.han@...sung.com>
> CC: Alan Stern <stern@...land.harvard.edu>
> CC: Kukjin Kim <kgene.kim@...sung.com>
> CC: Felipe Balbi <balbi@...com>
> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> ---
> 
> As this affects 3.9, this patch should definitely be considered for inclusion
> there.
> ---
>  drivers/usb/host/ehci-s5p.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-s5p.c b/drivers/usb/host/ehci-s5p.c
> index 20ebf6a..c6d67e4 100644
> --- a/drivers/usb/host/ehci-s5p.c
> +++ b/drivers/usb/host/ehci-s5p.c
> @@ -103,9 +103,15 @@ static void s5p_setup_vbus_gpio(struct platform_device *pdev)
>  	if (!gpio_is_valid(gpio))
>  		return;
>  
> -	err = gpio_request_one(gpio, GPIOF_OUT_INIT_HIGH, "ehci_vbus_gpio");
> -	if (err)
> +	/* reset pulls the line down, then up again */
> +	err = gpio_request_one(gpio, GPIOF_OUT_INIT_LOW, "ehci_vbus_gpio");
> +	if (err) {
>  		dev_err(&pdev->dev, "can't request ehci vbus gpio %d", gpio);
> +		return;
> +	}
> +	mdelay(1);
> +	__gpio_set_value(gpio, 1);
> +	gpio_free(gpio);
>  }
>  
>  static u64 ehci_s5p_dma_mask = DMA_BIT_MASK(32);

Acked-by: Alan Stern <stern@...land.harvard.edu>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/