linux-kernel - Re: [PATCH v2, part1 25/29] mm/x86: use common help functions to free reserved pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5140AD31.30907@gmail.com>
Date:	Thu, 14 Mar 2013 00:45:37 +0800
From:	Jiang Liu <liuj97@...il.com>
To:	Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	David Rientjes <rientjes@...gle.com>,
	Jiang Liu <jiang.liu@...wei.com>,
	Wen Congyang <wency@...fujitsu.com>,
	Maciej Rutecki <maciej.rutecki@...il.com>,
	Chris Clayton <chris2553@...glemail.com>,
	"Rafael J . Wysocki" <rjw@...k.pl>, Mel Gorman <mgorman@...e.de>,
	Minchan Kim <minchan@...nel.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Michal Hocko <mhocko@...e.cz>,
	Jianguo Wu <wujianguo@...wei.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH v2, part1 25/29] mm/x86: use common help functions to
 free reserved pages

On 03/13/2013 01:38 PM, Yasuaki Ishimatsu wrote:
> Hi Jiang,
> 
> 2013/03/10 15:27, Jiang Liu wrote:
>> Use common help functions to free reserved pages.
>>
>> Signed-off-by: Jiang Liu <jiang.liu@...wei.com>
>> Cc: Thomas Gleixner <tglx@...utronix.de>
>> Cc: Ingo Molnar <mingo@...hat.com>
>> Cc: "H. Peter Anvin" <hpa@...or.com>
>> ---
>>   arch/x86/mm/init.c    |    5 +----
>>   arch/x86/mm/init_64.c |    5 ++---
>>   2 files changed, 3 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
>> index 4903a03..4a705e6 100644
>> --- a/arch/x86/mm/init.c
>> +++ b/arch/x86/mm/init.c
>> @@ -516,11 +516,8 @@ void free_init_pages(char *what, unsigned long begin, unsigned long end)
> 
>>   	printk(KERN_INFO "Freeing %s: %luk freed\n", what, (end - begin) >> 10);
>>   
>>   	for (; addr < end; addr += PAGE_SIZE) {
>> -		ClearPageReserved(virt_to_page(addr));
>> -		init_page_count(virt_to_page(addr));
>>   		memset((void *)addr, POISON_FREE_INITMEM, PAGE_SIZE);
>> -		free_page(addr);
>> -		totalram_pages++;
>> +		free_reserved_page(virt_to_page(addr));
>>   	}
> 
> If I don't misread your code, avobe codes can replace to free_reserved_area()
> as follow:
> 
> 	free_reserved_area(addr, end, POISON_FREE_INITMEM, what)
> 
> Am I wrong?
Hi Yasuaki,
	Good catch, will enhance it in following patches.
	Thanks!

> 
> Thanks,
> Yasuaki Ishimatsu
> 
>>   #endif
>>   }
>> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
>> index 474e28f..2ef81f1 100644
>> --- a/arch/x86/mm/init_64.c
>> +++ b/arch/x86/mm/init_64.c
>> @@ -1067,10 +1067,9 @@ void __init mem_init(void)
>>   
>>   	/* clear_bss() already clear the empty_zero_page */
>>   
>> -	reservedpages = 0;
>> -
>> -	/* this will put all low memory onto the freelists */
>>   	register_page_bootmem_info();
>> +
>> +	/* this will put all memory onto the freelists */
>>   	totalram_pages = free_all_bootmem();
>>   
>>   	absent_pages = absent_pages_in_range(0, max_pfn);
>>
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/