| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20130313165622.GA19692@tassilo.jf.intel.com>
Date: Wed, 13 Mar 2013 09:56:22 -0700
From: Andi Kleen <ak@...ux.intel.com>
To: Stephane Eranian <eranian@...gle.com>
Cc: Andi Kleen <andi@...stfloor.org>,
Arnaldo Carvalho de Melo <acme@...hat.com>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf, tools: Make perf stat -I ... CSV output flat
On Wed, Mar 13, 2013 at 02:19:05PM +0100, Stephane Eranian wrote:
> On Thu, Mar 7, 2013 at 3:43 AM, Andi Kleen <andi@...stfloor.org> wrote:
> > From: Andi Kleen <ak@...ux.intel.com>
> >
> > The new perf stat interval code is quite useful, especially when the
> > data is post processed. Unfortunately the default -x, output is not
> > very friendly to programs when it contains more than one event.
> >
> > Each event is printed on its own line, each keyed with the time.
> >
> > You cannot directly feed it to gnuplot or into R to
> > compare different events at a specific point in time.
> >
> > This patch normalizes the output so that a single line contains all
> > the events for a given time period. Each event is an own column.
> >
> > With that it's quite easy to do plots and other analysis,
> > as this is the normalized format many data processing programs expect.
> >
> > This is not fully normalized yet, as per cpu counts also
> > end up on the same line (fixing this would be more intrusive)
> > But good enough for most purposes.
> >
> > The non CSV output is not changed.
> >
> > Example:
> >
> > $ perf stat -o /tmp/x.csv -I 100 -x, bc <<< 2^400000 > /dev/null
> > $ gnuplot
> > gnuplot> set datafile separator ","
> > gnuplot> set terminal dumb
> > gnuplot> plot "/tmp/x.csv" every ::3 using 1:3
> >
> > 110 ++--------+---------+---------+--------+---------+---------+--------++
> > + + + "/tmp/x.csv" every ::3 using 1:3 A +
> > 100 ++ A A A A A A A A A A A A ++
> > 90 ++ ++
> > | |
> > 80 ++ ++
> > | |
> > 70 ++ ++
> > | |
> > 60 ++ ++
> > 50 ++ ++
> > | |
> > 40 ++ ++
> > | |
> > 30 ++ ++
> > | |
> > 20 ++ ++
> > 10 ++ ++
> > + + + + + + +A +
> > 0 ++--------+---------+---------+--------+---------+---------+--------++
> > 0.2 0.4 0.6 0.8 1 1.2 1.4 1.6
> >
> > Cc: eranian@...gle.com
> > ---
> > tools/perf/builtin-stat.c | 118 +++++++++++++++++++++++++++++++--------------
> > 1 files changed, 82 insertions(+), 36 deletions(-)
> >
> > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> > index e6f4d1d..81d704a 100644
> > --- a/tools/perf/builtin-stat.c
> > +++ b/tools/perf/builtin-stat.c
> > @@ -66,8 +66,10 @@
> > #define CNTR_NOT_COUNTED "<not counted>"
> >
> > static void print_stat(int argc, const char **argv);
> > -static void print_counter_aggr(struct perf_evsel *counter, char *prefix);
> > -static void print_counter(struct perf_evsel *counter, char *prefix);
> > +static void print_counter_aggr(struct perf_evsel *counter, char *prefix, int delim,
> > + int name);
> > +static void print_counter(struct perf_evsel *counter, char *prefix, int delim,
> > + int name);
> > static void print_aggr_socket(char *prefix);
> >
> > /* Default events used for perf stat -T */
> > @@ -343,6 +345,7 @@ static void print_interval(void)
> > struct perf_stat *ps;
> > struct timespec ts, rs;
> > char prefix[64];
> > + int delim = '\n';
> >
> > if (no_aggr) {
> > list_for_each_entry(counter, &evsel_list->entries, node) {
> > @@ -373,15 +376,23 @@ static void print_interval(void)
> > if (++num_print_interval == 25)
> > num_print_interval = 0;
> >
> > + if (csv_output) {
> > + delim = ',';
> > + fprintf(output, "%s,", prefix);
> > + prefix[0] = 0;
> > + }
> > +
> > if (aggr_socket)
> > print_aggr_socket(prefix);
> > else if (no_aggr) {
> > list_for_each_entry(counter, &evsel_list->entries, node)
> > - print_counter(counter, prefix);
> > + print_counter(counter, prefix, delim, !csv_output);
> > } else {
> > list_for_each_entry(counter, &evsel_list->entries, node)
> > - print_counter_aggr(counter, prefix);
> > + print_counter_aggr(counter, prefix, delim, !csv_output);
> > }
> > + if (csv_output)
> > + fputc('\n', output);
> > }
> >
> > static int __run_perf_stat(int argc __maybe_unused, const char **argv)
> > @@ -503,6 +514,21 @@ static int __run_perf_stat(int argc __maybe_unused, const char **argv)
> > t0 = rdclock();
> > clock_gettime(CLOCK_MONOTONIC, &ref_time);
> >
> > + if (interval && csv_output) {
> > + fprintf(output, "time,,");
>
> Don't quite understand the point of the ,,. By definition this
> extension is used for automatic
That was for one of the extra modi, I think cgroups.
It was easier to have the extra empty column than to special case this.
> in system-wide mode:
>
> $ perf stat -I 10000 -x, -a -A -e cycles,instructions sleep 5
>
> Don't you want events also grouped by CPU?
I mentioned that as an open. It would be good to have separate lines
per cpu, but that would have complicated the patch somewhat.
Could be done as a next step I suppose.
-Andi
--
ak@...ux.intel.com -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists