linux-kernel - Re: [PATCH] workqueue: missing idr_preload_end() in worker_pool_assign

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130313175745.GA22267@htj.dyndns.org>
Date:	Wed, 13 Mar 2013 10:57:45 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Artem Savkov <artem.savkov@...il.com>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	viakernel.org@....dyndns.org, linux-next@...r.kernel.org
Subject: Re: [PATCH] workqueue: missing idr_preload_end() in
 worker_pool_assign_id()

(cc'ing Stephen and linux-next)

Hello, Artem.

On Wed, Mar 13, 2013 at 09:51:32PM +0400, Artem Savkov wrote:
> Added missing idr_preload_end() call in worker_pool_assign_id().
> Without it preemption stays disabled resulting in lots of "scheduling while
> atomic" BUGs during boot.
...
> Introduced in "workqueue: convert to idr_alloc()"

That patch doesn't use idr_preload().  It looks like the issue is
introduced during linux-next merge of wq/for-3.10 and idr patches in
-mm.  Stephen, can you please add idr_preload_end() to the merge
patch?

Once the idr patches land in Linus' tree, I'll resolve the conflict
from wq tree side.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/