linux-kernel - Re: [PATCH 0/9] overlay filesystem: request for inclusion (v17)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130313181251.GA6023@sgi.com>
Date:	Wed, 13 Mar 2013 13:12:51 -0500
From:	Robin Holt <holt@....com>
To:	Sedat Dilek <sedat.dilek@...il.com>
Cc:	Miklos Szeredi <miklos@...redi.hu>, viro@...iv.linux.org.uk,
	torvalds@...ux-foundation.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, hch@...radead.org,
	akpm@...ux-foundation.org, apw@...onical.com, nbd@...nwrt.org,
	neilb@...e.de, jordipujolp@...il.com, ezk@....cs.sunysb.edu,
	dhowells@...hat.com, sedat.dilek@...glemail.com,
	hooanon05@...oo.co.jp, mszeredi@...e.cz
Subject: Re: [PATCH 0/9] overlay filesystem: request for inclusion (v17)

On Wed, Mar 13, 2013 at 05:51:33PM +0100, Sedat Dilek wrote:
> On Wed, Mar 13, 2013 at 5:21 PM, Miklos Szeredi <miklos@...redi.hu> wrote:
> > On Wed, Mar 13, 2013 at 5:10 PM, Sedat Dilek <sedat.dilek@...il.com> wrote:
> >
> >> Anyway, with CONFIG_OVERLAYFS_FS=m I do not see any related messages
> >> when the kernel-module is loaded.
> >> So, is this intended?
> >> SquashFS prints into the logs, so what is it doing differently?
> >
> > Some modules do, some don't.  It's not compulsory and not very useful.
> >
> 
> What about...
> 
> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
> index 482c26f..92b9ad5 100644
> --- a/fs/overlayfs/super.c
> +++ b/fs/overlayfs/super.c
> @@ -675,11 +675,13 @@ MODULE_ALIAS_FS("overlayfs");
>  static int __init ovl_init(void)
>  {
>         return register_filesystem(&ovl_fs_type);
> +       printk(KERN_INFO "overlayfs: loaded\n");

How about pr_debug().  That makes things quite for most of us but gives
you info when looking for things like boot problems.

>  }
> 
>  static void __exit ovl_exit(void)
>  {
>         unregister_filesystem(&ovl_fs_type);
> +       printk(KERN_INFO "overlayfs: unloaded\n");
>  }
> 
>  module_init(ovl_init);
> 
> Maybe "loaded" is enough.
> 
> - Sedat -
> 
> > Thanks,
> > Miklos
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/