linux-kernel - Re: [PATCH] arch: s390: mm: Use PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130313191034.GM21522@ZenIV.linux.org.uk>
Date:	Wed, 13 Mar 2013 19:10:34 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Alexandru Gheorghiu <gheorghiuandru@...il.com>
Cc:	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	linux390@...ibm.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arch: s390: mm: Use PTR_RET function

On Wed, Mar 13, 2013 at 09:05:57PM +0200, Alexandru Gheorghiu wrote:
> Used PTR_RET function instead of IS_ERR and PTR_ERR.
> Patch found using coccinelle.
> 
> Signed-off-by: Alexandru Gheorghiu <gheorghiuandru@...il.com>
> ---
>  arch/s390/mm/cmm.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/s390/mm/cmm.c b/arch/s390/mm/cmm.c
> index 479e942..5cf867f 100644
> --- a/arch/s390/mm/cmm.c
> +++ b/arch/s390/mm/cmm.c
> @@ -458,7 +458,7 @@ static int __init cmm_init(void)
>  	if (rc)
>  		goto out_pm;
>  	cmm_thread_ptr = kthread_run(cmm_thread, NULL, "cmmthread");
> -	rc = IS_ERR(cmm_thread_ptr) ? PTR_ERR(cmm_thread_ptr) : 0;
> +	rc = PTR_RET(cmm_thread_ptr);
>  	if (rc)
>  		goto out_kthread;
>  	return 0;

Egads...  How about
	if (!IS_ERR(cmm_thread_ptr))
		return 0;
	rc = PTR_ERR(cmm_thread_ptr);
instead of the entire thing?  out_kthread: is just past that return 0
and there's nothing else leading to it, so with that change the label
itself can go as well.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/