linux-kernel - Re: [PATCH] efivars: Allow disabling use as a pstore backend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1363203873.15011.311.camel@mfleming-mobl1.ger.corp.intel.com>
Date:	Wed, 13 Mar 2013 19:44:33 +0000
From:	Matt Fleming <matt.fleming@...el.com>
To:	Seth Forshee <seth.forshee@...onical.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Matthew Garrett <matthew.garrett@...ula.com>,
	linux-kernel@...r.kernel.org, linux-efi@...r.kernel.org
Subject: Re: [PATCH] efivars: Allow disabling use as a pstore backend

On Wed, 2013-03-13 at 14:14 -0500, Seth Forshee wrote:
> On Wed, Mar 13, 2013 at 06:33:37PM +0000, Matt Fleming wrote:
> > On Wed, 2013-03-13 at 10:25 -0700, H. Peter Anvin wrote:
> > > I think there should be two compile-time options (one to compile in the
> > > EFI pstore code at all, and one to set its default.)
> > 
> > OK, sorry Seth, looks like I'm the one that misunderstood. I've picked
> > up your first two patches and pushed them out to the urgent branch.
> > Please check that they look OK - they required minor fixups.
> 
> A minor nit from the second patch:
> 
> +static bool efivars_pstore_disable = \
> +       IS_ENABLED(EFI_VARS_PSTORE_DEFAULT_DISABLE);
> 
> The backslash isn't necessary.

Whoops. Fixed.

> Otherwise everything looks fine afaict.

Thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/