linux-kernel - Re: [PATCH 0/9] overlay filesystem: request for inclusion (v17)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 Mar 2013 12:54:51 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	sedat.dilek@...il.com
Cc:	Felix Fietkau <nbd@...nwrt.org>, Robin Holt <holt@....com>,
	Miklos Szeredi <miklos@...redi.hu>, viro@...iv.linux.org.uk,
	torvalds@...ux-foundation.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, hch@...radead.org,
	akpm@...ux-foundation.org, apw@...onical.com, neilb@...e.de,
	jordipujolp@...il.com, ezk@....cs.sunysb.edu, dhowells@...hat.com,
	sedat.dilek@...glemail.com, hooanon05@...oo.co.jp, mszeredi@...e.cz
Subject: Re: [PATCH 0/9] overlay filesystem: request for inclusion (v17)

Sedat Dilek <sedat.dilek@...il.com> writes:

> On Wed, Mar 13, 2013 at 7:37 PM, Felix Fietkau <nbd@...nwrt.org> wrote:
>> On 2013-03-13 7:12 PM, Robin Holt wrote:
>>> On Wed, Mar 13, 2013 at 05:51:33PM +0100, Sedat Dilek wrote:
>>>> On Wed, Mar 13, 2013 at 5:21 PM, Miklos Szeredi <miklos@...redi.hu> wrote:
>>>> > On Wed, Mar 13, 2013 at 5:10 PM, Sedat Dilek <sedat.dilek@...il.com> wrote:
>>>> >
>>>> >> Anyway, with CONFIG_OVERLAYFS_FS=m I do not see any related messages
>>>> >> when the kernel-module is loaded.
>>>> >> So, is this intended?
>>>> >> SquashFS prints into the logs, so what is it doing differently?
>>>> >
>>>> > Some modules do, some don't.  It's not compulsory and not very useful.
>>>> >
>>>>
>>>> What about...
>>>>
>>>> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
>>>> index 482c26f..92b9ad5 100644
>>>> --- a/fs/overlayfs/super.c
>>>> +++ b/fs/overlayfs/super.c
>>>> @@ -675,11 +675,13 @@ MODULE_ALIAS_FS("overlayfs");
>>>>  static int __init ovl_init(void)
>>>>  {
>>>>         return register_filesystem(&ovl_fs_type);
>>>> +       printk(KERN_INFO "overlayfs: loaded\n");
>>>
>>> How about pr_debug().  That makes things quite for most of us but gives
>>> you info when looking for things like boot problems.
>> How is having a printk/pr_debug useful here at all? The fact that other
>> filesystems do this as well is not a good reason...
>> Also, putting it *after* the return statement doesn't make much sense ;)
>>
>
> Hehe, I just checked my new kernel... that does not work (nothing in the logs).
> But I think it's good to see if the filesystem is registered/loaded.

lsmod | grep overlayfs

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/