linux-kernel - Re: linux-next: manual merge of the akpm tree with the workqueues tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130313205147.GB22267@htj.dyndns.org>
Date:	Wed, 13 Mar 2013 13:51:47 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: linux-next: manual merge of the akpm tree with the workqueues
 tree

Hello, Andrew.

On Wed, Mar 13, 2013 at 12:46:24PM -0700, Andrew Morton wrote:
> Tejun, can you please confirm that this is how worker_pool_assign_id()
> should look in linux-next?
> 
> static int worker_pool_assign_id(struct worker_pool *pool)
> {
> 	int ret;
> 
> 	do {
> 		idr_preload(GFP_KERNEL);
> 		spin_lock_irq(&workqueue_lock);
> 		ret = idr_alloc(&worker_pool_idr, pool, 0, 0, GFP_NOWAIT);
> 		if (ret >= 0)
> 			pool->id = ret;
> 		spin_unlock_irq(&workqueue_lock);

		idr_preload_end();

> 	} while (ret == -EAGAIN);
> 
> 	return ret < 0 ? ret : 0;
> }

Other than that, it looks good to me.

Thanks!

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/