linux-kernel - Re: [PATCH v5 1/2] mm: limit growth of 3% hardcoded other user reserve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130313140102.234330566fd08a0c8e4e2732@linux-foundation.org>
Date:	Wed, 13 Mar 2013 14:01:02 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Andrew Shewmaker <agshew@...il.com>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	alan@...rguk.ukuu.org.uk, simon.jeons@...il.com,
	ric.masonn@...il.com
Subject: Re: [PATCH v5 1/2] mm: limit growth of 3% hardcoded other user
 reserve

On Wed, 6 Mar 2013 20:55:53 -0500 Andrew Shewmaker <agshew@...il.com> wrote:

> Should I enforce a minimum for the admin reserve? 8MB/128MB for the 
> overcommit guess/never modes? I was hesitant to do that since my 
> numbers are based a full-featured distro's versions of login, bash,
> etc. A more svelte distro based on BusyBox might want different 
> minimums.

I'd say not.  It requires CAP_SYS_ADMIN and we generally prefer to give
root the flexibility to shoot his foot off if he feels so inclined.

> I have a question concerning the variable names. Might a person 
> looking at the source be confused why admin_reserve_kbytes and 
> user_reserve_kbytes are not included in totalreserve_pages? Should 
> I use a word other than "reserve" in the names, like "safetynet"? 
> I can't think of anything better. Maybe it isn't a concern, but 
> I didn't want to cause confusion.

mm..  I wouldn't worry about it personally.  As long as we have nice
comments at the various definition sites, readers should be able to
work out the difference quite easily.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/