linux-kernel - Re: [PATCH 1/1] module: fix symbol versioning with symbol prefixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51419686.7080405@imgtec.com>
Date:	Thu, 14 Mar 2013 09:21:10 +0000
From:	James Hogan <james.hogan@...tec.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
CC:	<linux-kernel@...r.kernel.org>, Michal Marek <mmarek@...e.cz>,
	"Sam Ravnborg" <sam@...nborg.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jonathan Kliegman <kliegs@...omium.org>
Subject: Re: [PATCH 1/1] module: fix symbol versioning with symbol prefixes

On 13/03/13 23:51, Rusty Russell wrote:
> James Hogan <james.hogan@...tec.com> writes:
>> Fix symbol versioning on architectures with symbol prefixes. Although
>> the build was free from warnings the actual modules still wouldn't load
>> as the ____versions table contained unprefixed symbol names, which were
>> being compared against the prefixed symbol names when checking the
>> symbol versions.
>>
>> This is fixed by modifying modpost to add the symbol prefix to the
>> ____versions table it outputs (Modules.symvers still contains unprefixed
>> symbol names). The check_modstruct_version() function is also fixed as
>> it checks the version of the unprefixed "module_layout" symbol which
>> would no longer work.
> 
> Hmm, this has always been broken, right?  And noone noticed?  Unless you
> really want it now, I'll queue it for *next* merge window.

Yes, that's fine by me.

> I've applied it (reworked) to my pending-rebases queue, and will put it
> in modules-next once the cleanup goes in.

Thanks
James

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/