linux-kernel - [PATCH] sched,trace: Allow tracing the preemption decision on wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1363254519.26965.9.camel@laptop>
Date:	Thu, 14 Mar 2013 10:48:39 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	mingo@...nel.org, tglx <tglx@...utronix.de>,
	Steven Rostedt <rostedt@...dmis.org>
Cc:	Mike Galbraith <efault@....de>, Paul Turner <pjt@...gle.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] sched,trace: Allow tracing the preemption decision on wakeup

Thomas noted that we do the wakeup preemption check after the wakeup
trace point, this means the tracepoint cannot test/report this decision;
which is rather important for latency sensitive workloads. Therefore
move the tracepoint after doing the preemption check.

Suggested-by: Thomas Gleixner <tglx@...utronix.de>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
---
 kernel/sched/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index b36635e..849deb9 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -1288,8 +1288,8 @@ static void ttwu_activate(struct rq *rq, struct task_struct *p, int en_flags)
 static void
 ttwu_do_wakeup(struct rq *rq, struct task_struct *p, int wake_flags)
 {
-	trace_sched_wakeup(p, true);
 	check_preempt_curr(rq, p, wake_flags);
+	trace_sched_wakeup(p, true);
 
 	p->state = TASK_RUNNING;
 #ifdef CONFIG_SMP


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/