linux-kernel - Re: [PATCH 1/1] scripts/package/Makefile: compare objtree with srctree instead of test KBUILD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD_32VUREUgiBt2ScK31ig-p8282g7VZta+Q6Fq0pkEaDGxm+A@mail.gmail.com>
Date:	Thu, 14 Mar 2013 09:30:32 +0800
From:	Bin Wang <wbin00@...il.com>
To:	mmarek@...e.cz, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] scripts/package/Makefile: compare objtree with
 srctree instead of test KBUILD_OUTPUT

Hi, Michal

Is there any comments on this?

2013/2/25 Bin Wang <wbin00@...il.com>:
> KBUILD_OUTPUT is always empty here, so it is useless to test it. But
> while use O=.., objtree and srctree will be different. I compare them
> instead.
>
> Signed-off-by: Bin Wang <wbin00@...il.com>
> ---
>  scripts/package/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/package/Makefile b/scripts/package/Makefile
> index 87bf080..d7b3285 100644
> --- a/scripts/package/Makefile
> +++ b/scripts/package/Makefile
> @@ -36,7 +36,7 @@ $(objtree)/kernel.spec: $(MKSPEC) $(srctree)/Makefile
>         $(CONFIG_SHELL) $(MKSPEC) > $@
>
>  rpm-pkg rpm: $(objtree)/kernel.spec FORCE
> -       @if test -n "$(KBUILD_OUTPUT)"; then \
> +       @if test "$(objtree)" != "$(srctree)"; then \
>                 echo "Building source + binary RPM is not possible outside the"; \
>                 echo "kernel source tree. Don't set KBUILD_OUTPUT, or use the"; \
>                 echo "binrpm-pkg target instead."; \
> --
> 1.8.1.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/