linux-kernel - Re: [PATCH 1/2] usb: dwc3: exynos: Use of_platform API to create dwc3 core pdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130314105155.GG32369@arwen.pp.htv.fi>
Date:	Thu, 14 Mar 2013 12:51:55 +0200
From:	Felipe Balbi <balbi@...com>
To:	Vivek Gautam <gautam.vivek@...sung.com>
CC:	<linux-usb@...r.kernel.org>, <linux-samsung-soc@...r.kernel.org>,
	<devicetree-discuss@...ts.ozlabs.org>,
	<linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	<gregkh@...uxfoundation.org>, <balbi@...com>,
	<rob.herring@...xeda.com>, <kgene.kim@...sung.com>,
	<thomas.abraham@...aro.org>, <dianders@...omium.org>,
	Kishon Vijay Abraham I <kishon@...com>
Subject: Re: [PATCH 1/2] usb: dwc3: exynos: Use of_platform API to create
 dwc3 core pdev

Hi,

On Thu, Mar 14, 2013 at 04:14:57PM +0530, Vivek Gautam wrote:
> @@ -170,7 +155,6 @@ static int dwc3_exynos_remove(struct platform_device *pdev)
>  {
>  	struct dwc3_exynos	*exynos = platform_get_drvdata(pdev);
>  
> -	platform_device_unregister(exynos->dwc3);

don't you want to do what Kishon did here and have:

static int dwc3_exynos_remove_child(struct device *dev, void *unused)
{
	struct platform_device	*pdev = to_platform_device(dev);

	platform_device_unregister(pdev);

	return 0;
}

device_for_each_child(&pdev->dev, NULL, dwc3_exynos_remove_child);

???

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)