linux-kernel - [PATCH] x84: reenable DEBUG_TLBFLUSH for X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1363262077.1335.71.camel@x61.thuisdomein>
Date:	Thu, 14 Mar 2013 12:54:37 +0100
From:	Paul Bolle <pebolle@...cali.nl>
To:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] x84: reenable DEBUG_TLBFLUSH for X86_32

CONFIG_INVLPG got removed in commit
094ab1db7cb7833cd4c820acd868fc26acf3f08e ("x86, 386 removal: Remove
CONFIG_INVLPG"). That commit left one instance of CONFIG_INVLPG
untouched, effectively disabling DEBUG_TLBFLUSH for X86_32. Since all
currently supported X86 CPU's should now be able to support that option,
just drop the entire sub-dependency.

Signed-off-by: Paul Bolle <pebolle@...cali.nl>
---
0) Untested! This needs testing by the subsection of people running
DEBUG_TLBFLUSH on X86_32. I'm not in that subsection.

1) I actually wonder whether this check was needed in the first place.
It seems that the code depending on CONFIG_DEBUG_TLBFLUSH in
arch/x86/mm/tlb.c was actually safe to be called on any X86 CPU, since
it used to test for cpu_has_invlpg. But none of that matters anymore.

 arch/x86/Kconfig.debug | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
index b322f12..16f7383 100644
--- a/arch/x86/Kconfig.debug
+++ b/arch/x86/Kconfig.debug
@@ -131,7 +131,7 @@ config DOUBLEFAULT

 config DEBUG_TLBFLUSH
 	bool "Set upper limit of TLB entries to flush one-by-one"
-	depends on DEBUG_KERNEL && (X86_64 || X86_INVLPG)
+	depends on DEBUG_KERNEL
 	---help---

 	X86-only for now.
-- 
1.7.11.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/