linux-kernel - Re: [PATCH] X.509: Remove certificate date checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1363265300.4853.37.camel@i7.infradead.org>
Date:	Thu, 14 Mar 2013 12:48:20 +0000
From:	David Woodhouse <dwmw2@...radead.org>
To:	David Howells <dhowells@...hat.com>
Cc:	rusty@...tcorp.com.au, torvalds@...ux-foundation.org,
	keyrings@...ux-nfs.org, Josh Boyer <jwboyer@...hat.com>,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Alexander Holler <holler@...oftware.de>
Subject: Re: [PATCH] X.509: Remove certificate date checks

On Thu, 2013-03-14 at 12:34 +0000, David Howells wrote:
> Remove the certificate date checks that are performed when a certificate is
> parsed.  There are two checks: a valid from and a valid to.  The first check is
> causing a lot of problems with system clocks that don't keep good time and the
> second places an implicit expiry date upon the kernel when used for module
> signing, so do we really need them?

While the date check is entirely bogus for the specific case of module
signing, I don't think we necessarily ought to rip it out of our generic
X.509 support entirely.

Some use cases *might* want to check the dates, and should be permitted
to do so. Just don't refuse to even *parse* the key outside its valid
date range... :)

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@...el.com                              Intel Corporation

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (6171 bytes)