linux-kernel - RE: [PATCH 2/3] pwm: pwm-tiecap: Add device-tree binding support for da850 SOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <518397C60809E147AF5323E0420B992E3EA96FA1@DBDE01.ent.ti.com>
Date:	Thu, 14 Mar 2013 12:54:08 +0000
From:	"Philip, Avinash" <avinashphilip@...com>
To:	"Nori, Sekhar" <nsekhar@...com>
CC:	"thierry.reding@...onic-design.de" <thierry.reding@...onic-design.de>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"davinci-linux-open-source@...ux.davincidsp.com" 
	<davinci-linux-open-source@...ux.davincidsp.com>,
	"Manjunathappa, Prakash" <prakash.pm@...com>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <rob.herring@...xeda.com>,
	Rob Landley <rob@...dley.net>
Subject: RE: [PATCH 2/3] pwm: pwm-tiecap: Add device-tree binding support
 for da850 SOC

On Thu, Mar 14, 2013 at 17:13:08, Nori, Sekhar wrote:
> On 3/14/2013 4:02 PM, Philip Avinash wrote:
> > ECAP IP is used in da850 SOC's also. Hence adds ECAP device tree binding
> > support for da850.
> > 
> > Cc: Grant Likely <grant.likely@...retlab.ca>
> > Cc: Rob Herring <rob.herring@...xeda.com>
> > Cc: Rob Landley <rob@...dley.net>
> > Signed-off-by: Philip Avinash <avinashphilip@...com>
> > ---
> > :100644 100644 131e8c1... fcbd3c1... M	Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> > :100644 100644 22e96e2... e0d96c8... M	drivers/pwm/pwm-tiecap.c
> >  .../devicetree/bindings/pwm/pwm-tiecap.txt         |    2 +-
> >  drivers/pwm/pwm-tiecap.c                           |    1 +
> >  2 files changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> > index 131e8c1..fcbd3c1 100644
> > --- a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> > +++ b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> > @@ -1,7 +1,7 @@
> >  TI SOC ECAP based APWM controller
> >  
> >  Required properties:
> > -- compatible: Must be "ti,am33xx-ecap"
> > +- compatible: Must be "ti,am33xx-ecap" or "ti,da850-ecap"
> >  - #pwm-cells: Should be 3. Number of cells being used to specify PWM property.
> >    First cell specifies the per-chip index of the PWM to use, the second
> >    cell is the period in nanoseconds and bit 0 in the third cell is used to
> > diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
> > index 22e96e2..e0d96c8 100644
> > --- a/drivers/pwm/pwm-tiecap.c
> > +++ b/drivers/pwm/pwm-tiecap.c
> > @@ -197,6 +197,7 @@ static const struct pwm_ops ecap_pwm_ops = {
> >  
> >  static const struct of_device_id ecap_of_match[] = {
> >  	{ .compatible	= "ti,am33xx-ecap" },
> > +	{ .compatible	= "ti,da850-ecap" },
> >  	{},
> 
> You add a new compatible, but don't really show any changes in driver in
> this series. So why can't we simply use ti,am33xx-ecap on DA850 too?

Ok it can happily live with ti,am33xx-ecap. Hence this patch and next [1]patch
can be dropped.

1. [PATCH 3/3] pwm: pwm-tiehrpwm: Add device tree binding support for da850 SOC

Thanks
Avinash
> 
> Thanks,
> Sekhar
>