linux-kernel - Re: [PATCH 01/10] drivers: media: use module_platform_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Mar 2013 14:25:46 +0100 (CET)
From:	Guennadi Liakhovetski <g.liakhovetski@....de>
To:	Fabio Porcedda <fabio.porcedda@...il.com>
cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-media@...r.kernel.org, linux-ide@...r.kernel.org,
	lm-sensors@...sensors.org, linux-input@...r.kernel.org,
	linux-fbdev@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Josh Wu <josh.wu@...el.com>,
	Hans Verkuil <hans.verkuil@...co.com>
Subject: Re: [PATCH 01/10] drivers: media: use module_platform_driver_probe()

Hi Fabio

On Thu, 14 Mar 2013, Fabio Porcedda wrote:

> This patch converts the drivers to use the
> module_platform_driver_probe() macro which makes the code smaller and
> a bit simpler.
> 
> Signed-off-by: Fabio Porcedda <fabio.porcedda@...il.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Mauro Carvalho Chehab <mchehab@...hat.com>
> Cc: Josh Wu <josh.wu@...el.com>
> Cc: Guennadi Liakhovetski <g.liakhovetski@....de>
> Cc: Hans Verkuil <hans.verkuil@...co.com>
> Cc: linux-media@...r.kernel.org

Thanks for the patch. Subtracting this series 
http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/61403 
you only need to convert atmel-isi.c. Please, respin.

Thanks
Guennadi

> ---
>  drivers/media/platform/sh_vou.c                | 13 +------------
>  drivers/media/platform/soc_camera/atmel-isi.c  | 12 +-----------
>  drivers/media/platform/soc_camera/mx1_camera.c | 13 +------------
>  3 files changed, 3 insertions(+), 35 deletions(-)
> 
> diff --git a/drivers/media/platform/sh_vou.c b/drivers/media/platform/sh_vou.c
> index 66c8da1..d853162 100644
> --- a/drivers/media/platform/sh_vou.c
> +++ b/drivers/media/platform/sh_vou.c
> @@ -1485,18 +1485,7 @@ static struct platform_driver __refdata sh_vou = {
>  	},
>  };
>  
> -static int __init sh_vou_init(void)
> -{
> -	return platform_driver_probe(&sh_vou, sh_vou_probe);
> -}
> -
> -static void __exit sh_vou_exit(void)
> -{
> -	platform_driver_unregister(&sh_vou);
> -}
> -
> -module_init(sh_vou_init);
> -module_exit(sh_vou_exit);
> +module_platform_driver_probe(sh_vou, sh_vou_probe);
>  
>  MODULE_DESCRIPTION("SuperH VOU driver");
>  MODULE_AUTHOR("Guennadi Liakhovetski <g.liakhovetski@....de>");
> diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b/drivers/media/platform/soc_camera/atmel-isi.c
> index 82dbf99..12ba31d 100644
> --- a/drivers/media/platform/soc_camera/atmel-isi.c
> +++ b/drivers/media/platform/soc_camera/atmel-isi.c
> @@ -1081,17 +1081,7 @@ static struct platform_driver atmel_isi_driver = {
>  	},
>  };
>  
> -static int __init atmel_isi_init_module(void)
> -{
> -	return  platform_driver_probe(&atmel_isi_driver, &atmel_isi_probe);
> -}
> -
> -static void __exit atmel_isi_exit(void)
> -{
> -	platform_driver_unregister(&atmel_isi_driver);
> -}
> -module_init(atmel_isi_init_module);
> -module_exit(atmel_isi_exit);
> +module_platform_driver_probe(atmel_isi_driver, atmel_isi_probe);
>  
>  MODULE_AUTHOR("Josh Wu <josh.wu@...el.com>");
>  MODULE_DESCRIPTION("The V4L2 driver for Atmel Linux");
> diff --git a/drivers/media/platform/soc_camera/mx1_camera.c b/drivers/media/platform/soc_camera/mx1_camera.c
> index 25b2a28..4389f43 100644
> --- a/drivers/media/platform/soc_camera/mx1_camera.c
> +++ b/drivers/media/platform/soc_camera/mx1_camera.c
> @@ -859,18 +859,7 @@ static struct platform_driver mx1_camera_driver = {
>  	.remove		= __exit_p(mx1_camera_remove),
>  };
>  
> -static int __init mx1_camera_init(void)
> -{
> -	return platform_driver_probe(&mx1_camera_driver, mx1_camera_probe);
> -}
> -
> -static void __exit mx1_camera_exit(void)
> -{
> -	return platform_driver_unregister(&mx1_camera_driver);
> -}
> -
> -module_init(mx1_camera_init);
> -module_exit(mx1_camera_exit);
> +module_platform_driver_probe(mx1_camera_driver, mx1_camera_probe);
>  
>  MODULE_DESCRIPTION("i.MX1/i.MXL SoC Camera Host driver");
>  MODULE_AUTHOR("Paulius Zaleckas <paulius.zaleckas@...tonika.lt>");
> -- 
> 1.8.1.5
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/