linux-kernel - Re: [PATCH 4/9] vfs: introduce clone_private

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Mar 2013 14:28:46 +0100
From:	Miklos Szeredi <miklos@...redi.hu>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	viro@...iv.linux.org.uk, torvalds@...ux-foundation.org,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	hch@...radead.org, apw@...onical.com, nbd@...nwrt.org,
	neilb@...e.de, jordipujolp@...il.com, ezk@....cs.sunysb.edu,
	dhowells@...hat.com, sedat.dilek@...glemail.com,
	hooanon05@...oo.co.jp, mszeredi@...e.cz
Subject: Re: [PATCH 4/9] vfs: introduce clone_private_mount()

On Wed, Mar 13, 2013 at 11:48 PM, Andrew Morton
<akpm@...ux-foundation.org> wrote:
> On Wed, 13 Mar 2013 15:16:28 +0100 Miklos Szeredi <miklos@...redi.hu> wrote:
>
>> From: Miklos Szeredi <mszeredi@...e.cz>
>>
>> Overlayfs needs a private clone of the mount, so create a function for
>> this and export to modules.
>>
>> ...
>>
>> +struct vfsmount *clone_private_mount(struct path *path)
>> +{
>> +     struct mount *old_mnt = real_mount(path->mnt);
>> +     struct mount *new_mnt;
>> +
>> +     if (IS_MNT_UNBINDABLE(old_mnt))
>> +             return ERR_PTR(-EINVAL);
>> +
>> +     down_read(&namespace_sem);
>> +     new_mnt = clone_mnt(old_mnt, path->dentry, CL_PRIVATE);
>> +     up_read(&namespace_sem);
>> +     if (!new_mnt)
>> +             return ERR_PTR(-ENOMEM);
>> +
>> +     return &new_mnt->mnt;
>> +}
>> +EXPORT_SYMBOL_GPL(clone_private_mount);
>
> So this one gets the _GPL?
>
> This is a new, exported-to-modules kernel interface function.  And it
> is undocumented?

Following documentation added:

/**
 * clone_private_mount - create a private clone of a path
 *
 * This creates a new vfsmount, which will be the clone of @path.  The new will
 * not be attached anywhere in the namespace and will be private (i.e. changes
 * to the originating mount won't be propagated into this).
 *
 * Release with mntput().
 */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/