linux-kernel - Re: [PATCH] hwmon: (pmbus) Fix krealloc() misuse in pmbus_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130314135927.GA16825@roeck-us.net>
Date:	Thu, 14 Mar 2013 06:59:27 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	Jean Delvare <khali@...ux-fr.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (pmbus) Fix krealloc() misuse in
 pmbus_add_attribute()

On Thu, Mar 14, 2013 at 01:30:20PM +0000, David Woodhouse wrote:
> If krealloc() returns NULL, it *doesn't* free the original. So any code
> of the form 'foo = krealloc(foo, …);' is almost certainly a bug.
> 
> Signed-off-by: David Woodhouse <David.Woodhouse@...el.com>

Good catch. Thanks a lot for the fix!

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/