linux-kernel - Re: [PATCH 2/2] task_work: check callback if it's NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130314144307.GB16136@redhat.com>
Date:	Thu, 14 Mar 2013 15:43:07 +0100
From:	Oleg Nesterov <oleg@...hat.com>
To:	liguang <lig.fnst@...fujitsu.com>
Cc:	viro@...iv.linux.org.uk, edumazet@...gle.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] task_work: check callback if it's NULL

On 03/14, liguang wrote:
>
> Signed-off-by: liguang <lig.fnst@...fujitsu.com>
> ---
>  kernel/task_work.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/task_work.c b/kernel/task_work.c
> index 0bf4258..f458b08 100644
> --- a/kernel/task_work.c
> +++ b/kernel/task_work.c
> @@ -75,7 +75,8 @@ void task_work_run(void)
>
>  		do {
>  			next = work->next;
> -			work->func(work);
> +			if (unlikely(work->func))
> +				work->func(work);

Why?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/