linux-kernel - Re: [PATCH] usb: gadget: remove MACH_OMAP_H4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Mar 2013 15:50:57 +0100
From:	Paul Bolle <pebolle@...cali.nl>
To:	balbi@...com
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: remove MACH_OMAP_H4_OTG

On Thu, 2013-03-14 at 16:13 +0200, Felipe Balbi wrote:
> On Mon, Mar 11, 2013 at 09:14:41PM +0100, Paul Bolle wrote:
> > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> > index 5a0c541..c65b5e2 100644
> > --- a/drivers/usb/gadget/Kconfig
> > +++ b/drivers/usb/gadget/Kconfig
> > @@ -194,7 +194,7 @@ config USB_FUSB300
> >  config USB_OMAP
> >  	tristate "OMAP USB Device Controller"
> >  	depends on ARCH_OMAP1
> > -	select ISP1301_OMAP if MACH_OMAP_H2 || MACH_OMAP_H3 || MACH_OMAP_H4_OTG
> > +	select ISP1301_OMAP if MACH_OMAP_H2 || MACH_OMAP_H3
> 
> could you, instead, just remove the entire line ? we have an overuse of
> select and this is one of those cases where it doesn't make sense.

Sure, but there's one problem: I need to come up with a descriptive
summary. "Remove "select" because Felipe told it makes no sense" might
not be good enough. Any hint why you think this entire line can be
dropped?


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/