linux-kernel - Re: [PATCH 2/3] ACPI video: Make logic a little easier to understand.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5142DE26.7020404@intel.com>
Date:	Fri, 15 Mar 2013 16:39:02 +0800
From:	Aaron Lu <aaron.lu@...el.com>
To:	Danny Baumann <dannybaumann@....de>
CC:	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Zhang Rui <rui.zhang@...el.com>, Len Brown <lenb@...nel.org>
Subject: Re: [PATCH 2/3] ACPI video: Make logic a little easier to understand.

On 03/14/2013 06:34 PM, Danny Baumann wrote:
> Make code paths a little easier to follow, and don't needlessly continue
> list iteration.

Same here, please add Signed-off-by tag.
Reviewed-by: Aaron Lu <aaron.lu@...el.com>

Thanks,
Aaron

> ---
>  drivers/acpi/video.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> index ef85574..d0fade7 100644
> --- a/drivers/acpi/video.c
> +++ b/drivers/acpi/video.c
> @@ -736,16 +736,17 @@ acpi_video_init_brightness(struct acpi_video_device *device)
>  		 */
>  		if (use_bios_initial_backlight) {
>  			for (i = 2; i < br->count; i++)
> -				if (level_old == br->levels[i])
> +				if (level_old == br->levels[i]) {
>  					level = level_old;
> +					break;
> +				}
>  		}
> -		goto set_level;
> +	} else {
> +		if (br->flags._BCL_reversed)
> +			level_old = (br->count - 1) - level_old;
> +		level = br->levels[level_old];
>  	}
>  
> -	if (br->flags._BCL_reversed)
> -		level_old = (br->count - 1) - level_old;
> -	level = br->levels[level_old];
> -
>  set_level:
>  	result = acpi_video_device_lcd_set_level(device, level);
>  	if (result)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/