linux-kernel - Re: [PATCH] leds: lp55xx: fix the sysfs read operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK5ve-Kk4=EyafvdV+1-fNV2HpjfvOhMoneDK6ahURZ0NRPQLw@mail.gmail.com>
Date:	Thu, 14 Mar 2013 17:39:56 -0700
From:	Bryan Wu <cooloney@...il.com>
To:	"Kim, Milo" <Milo.Kim@...com>
Cc:	"linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] leds: lp55xx: fix the sysfs read operation

On Thu, Mar 14, 2013 at 5:19 PM, Kim, Milo <Milo.Kim@...com> wrote:
> According to a sysfs documentation(Documentation/filesystem/sysfs.txt),
> scnprintf() should be used in a read operation method.
> It guarantees safe buffer size(PAGE_SIZE) which is allocated by the sysfs.
>

Oh, I missed that. Great, I merged it.
Thanks,
-Bryan

> Signed-off-by: Milo(Woogyom) Kim <milo.kim@...com>
> ---
>  drivers/leds/leds-lp5521.c        |    3 ++-
>  drivers/leds/leds-lp55xx-common.c |    4 ++--
>  2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/leds/leds-lp5521.c b/drivers/leds/leds-lp5521.c
> index 1001347..7f10304 100644
> --- a/drivers/leds/leds-lp5521.c
> +++ b/drivers/leds/leds-lp5521.c
> @@ -360,7 +360,8 @@ static ssize_t lp5521_selftest(struct device *dev,
>         mutex_lock(&chip->lock);
>         ret = lp5521_run_selftest(chip, buf);
>         mutex_unlock(&chip->lock);
> -       return sprintf(buf, "%s\n", ret ? "FAIL" : "OK");
> +
> +       return scnprintf(buf, PAGE_SIZE, "%s\n", ret ? "FAIL" : "OK");
>  }
>
>  /* device attributes */
> diff --git a/drivers/leds/leds-lp55xx-common.c b/drivers/leds/leds-lp55xx-common.c
> index 8a388a4..715a602 100644
> --- a/drivers/leds/leds-lp55xx-common.c
> +++ b/drivers/leds/leds-lp55xx-common.c
> @@ -80,7 +80,7 @@ static ssize_t lp55xx_show_current(struct device *dev,
>  {
>         struct lp55xx_led *led = dev_to_lp55xx_led(dev);
>
> -       return sprintf(buf, "%d\n", led->led_current);
> +       return scnprintf(buf, PAGE_SIZE, "%d\n", led->led_current);
>  }
>
>  static ssize_t lp55xx_store_current(struct device *dev,
> @@ -113,7 +113,7 @@ static ssize_t lp55xx_show_max_current(struct device *dev,
>  {
>         struct lp55xx_led *led = dev_to_lp55xx_led(dev);
>
> -       return sprintf(buf, "%d\n", led->max_current);
> +       return scnprintf(buf, PAGE_SIZE, "%d\n", led->max_current);
>  }
>
>  static DEVICE_ATTR(led_current, S_IRUGO | S_IWUSR, lp55xx_show_current,
> --
> 1.7.9.5
>
>
> Best Regards,
> Milo
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/