linux-kernel - Re: [PATCHv2, RFC 08/30] thp, mm: rewrite add_to_page_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130315132333.B8205E0085@blue.fi.intel.com>
Date:	Fri, 15 Mar 2013 15:23:33 +0200 (EET)
From:	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
To:	Hillf Danton <dhillf@...il.com>
Cc:	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Hugh Dickins <hughd@...gle.com>,
	Wu Fengguang <fengguang.wu@...el.com>, Jan Kara <jack@...e.cz>,
	Mel Gorman <mgorman@...e.de>, linux-mm@...ck.org,
	Andi Kleen <ak@...ux.intel.com>,
	Matthew Wilcox <matthew.r.wilcox@...el.com>,
	"Kirill A. Shutemov" <kirill@...temov.name>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2, RFC 08/30] thp, mm: rewrite add_to_page_cache_locked()
 to support huge pages

Hillf Danton wrote:
> On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov
> <kirill.shutemov@...ux.intel.com> wrote:
> > +       page_cache_get(page);
> > +       spin_lock_irq(&mapping->tree_lock);
> > +       page->mapping = mapping;
> > +       page->index = offset;
> > +       error = radix_tree_insert(&mapping->page_tree, offset, page);
> > +       if (unlikely(error))
> > +               goto err;
> > +       if (PageTransHuge(page)) {
> > +               int i;
> > +               for (i = 1; i < HPAGE_CACHE_NR; i++) {
> 			struct page *tail = page + i; to easy reader
> 
> > +                       page_cache_get(page + i);
> s/page_cache_get/get_page_foll/ ?

Why?

> > +                       page[i].index = offset + i;
> > +                       error = radix_tree_insert(&mapping->page_tree,
> > +                                       offset + i, page + i);
> > +                       if (error) {
> > +                               page_cache_release(page + i);
> > +                               break;
> > +                       }
> >                 }
> > -               radix_tree_preload_end();
> > -       } else
> > -               mem_cgroup_uncharge_cache_page(page);
> > -out:
> > +               if (error) {
> > +                       error = ENOSPC; /* no space for a huge page */
> s/E/-E/

Good catch! Thanks.

> > +                       for (i--; i > 0; i--) {
> > +                               radix_tree_delete(&mapping->page_tree,
> > +                                               offset + i);
> > +                               page_cache_release(page + i);
> > +                       }
> > +                       radix_tree_delete(&mapping->page_tree, offset);
> > +                       goto err;
> > +               }
> > +       }

-- 
 Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/