linux-kernel - Re: [PATCH v3] arm: fix a wrong value returned from CALLER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130315173452.GQ4977@n2100.arm.linux.org.uk>
Date:	Fri, 15 Mar 2013 17:34:52 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	kpark3469@...il.com
Cc:	keun-o.park@...driver.com, dave.martin@...aro.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3] arm: fix a wrong value returned from CALLER_ADDRn

On Thu, Mar 14, 2013 at 01:35:01PM +0900, kpark3469@...il.com wrote:
> From: Sahara <keun-o.park@...driver.com>
> 
> This makes return_address() return a correct value for CALLER_ADDRn.
> To have a correct value from CALLER_ADDRn, we need to fix three points.
> 
> * The unwind_frame() does not update frame->lr but frame->pc for backtrace.
> So frame->pc is meaningful for backtrace.
> 
> * data.level should be adjusted by adding 2 additional iteration levels.
> With the current +1 level adjustment, the result of CALLER_ADDR1 will
> be the same return address with CALLER_ADDR0.
> 
> * The initialization of data.addr to NULL is needed.
> When unwind_fame() fails right after data.level reaches zero,
> the routine returns data.addr which has uninitialized garbage value.
> 
> Signed-off-by: Sahara <keun-o.park@...driver.com>
> Reviewed-by: Dave Martin <dave.martin@...aro.org>

Please send this to the patch system.  I think we should let this sit
in -next for a bit (which we'll get anyway) to see what the effect is.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/