linux-kernel - Re: [PATCH 3/8] FMC: add core bus driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130315191729.GA11988@kroah.com>
Date:	Fri, 15 Mar 2013 12:17:29 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Alessandro Rubini <rubini@...dd.com>
Cc:	linux-kernel@...r.kernel.org,
	Juan David Gonzalez Cobas <dcobas@...n.ch>,
	"Emilio G. Cota" <cota@...ap.org>,
	Samuel Iglesias Gonsalvez <siglesias@...lia.com>,
	Rob Landley <rob@...dley.net>, linux-doc@...r.kernel.org
Subject: Re: [PATCH 3/8] FMC: add core bus driver

On Thu, Feb 21, 2013 at 07:14:01PM +0100, Alessandro Rubini wrote:
> -/* Every device must have a release method: provide a default */
> +/* We really have nothing to release in here */
>  static void __fmc_release(struct device *dev) { }

Then your implementation is wrong, and as per the documentation in the
kernel Documentation directory (kobject.txt), I get to make fun of you
in public for trying to do this :)

Please fix this up, this isn't ok.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/