linux-kernel - Re: [PATCH] usb: ehci-s5p: Use devm for requesting ehci_vbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=U5wiLnW_tYaaA8Nq7Y=wzTwckMkSDEJY1ZvwOY0=an9Q@mail.gmail.com>
Date:	Thu, 14 Mar 2013 20:15:49 -0700
From:	Doug Anderson <dianders@...omium.org>
To:	jg1.han@...sung.com
Cc:	Felipe Balbi <balbi@...com>, Alexander Graf <agraf@...e.de>,
	Vivek Gautam <gautam.vivek@...sung.com>,
	Alan Stern <stern@...land.harvard.edu>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Thomas Abraham <thomas.abraham@...aro.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: ehci-s5p: Use devm for requesting ehci_vbus_gpio

Jingoo,

On Thu, Mar 14, 2013 at 5:30 PM, Jingoo Han <jg1.han@...sung.com> wrote:
> Would you replace other '&pdev->dev' with 'dev' in s5p_setup_vbus_gpio()
> as below? It seems to be better for readability.

Yes, of course.  That was silly of me not to add the "dev" local and
not update the other places...  Thanks for your review!

-Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/