| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 Mar 2013 13:30:10 -0700 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: Grant Likely <grant.likely@...retlab.ca> Cc: linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] tty/serial: Fix uninitialized variable warning On Mon, Mar 04, 2013 at 09:35:07AM +0800, Grant Likely wrote: > drivers/tty/serial/8250/8250.c: In function 'serial_unlink_irq_chain': > drivers/tty/serial/8250/8250.c:1676:19: warning: 'i' may be used uninitialized in this function > > There isn't an actual bug here since the function tests the condition > that would cause i to be uninitialized before dereferencing i. However, > at least some versions of GCC complain as shown above. (in my case, > powerpc gcc 2.5.2). Initializing i to NULL makes it clear to GCC and the > casual code reviewer that i will not be dereferenced to a random > address. > > Signed-off-by: Grant Likely <grant.likely@...retlab.ca> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> > --- > Greg, some may argue that this is a tool problem, not a kernel problem, > but it is useful to me. If anyone objects I'm not going to spend any > time championing for this patch. Upgrade your tools to ones that work properly :) greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists