linux-kernel - Re: [PATCH] export.h: clarify comment in relation to avoiding includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87hakdtg94.fsf@rustcorp.com.au>
Date:	Fri, 15 Mar 2013 15:24:15 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	linux-kernel@...r.kernel.org
Cc:	Paul Gortmaker <paul.gortmaker@...driver.com>
Subject: Re: [PATCH] export.h: clarify comment in relation to avoiding includes

Paul Gortmaker <paul.gortmaker@...driver.com> writes:

> The existing comment indicated what was desired, but it didn't
> necessarily convey the reasoning behind it in an effective way.
>
> Cc: Rusty Russell <rusty@...tcorp.com.au>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
>  include/linux/export.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/export.h b/include/linux/export.h
> index 696c0f4..d14cf26 100644
> --- a/include/linux/export.h
> +++ b/include/linux/export.h
> @@ -5,8 +5,9 @@
>   * to reduce the amount of pointless cruft we feed to gcc when only
>   * exporting a simple symbol or two.
>   *
> - * If you feel the need to add #include <linux/foo.h> to this file
> - * then you are doing something wrong and should go away silently.
> + * More specifically, it was all the #include <linux/foo.h> lines in
> + * module.h that we wanted to avoid, so please avoid adding any such
> + * similar include lines here, if at all possible.
>   */
>  
>  /* Some toolchains use a `_' prefix for all user symbols. */
> -- 
> 1.8.1.2

I prefer that :)

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/