[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5144698B.9080703@ti.com>
Date: Sat, 16 Mar 2013 08:46:03 -0400
From: Eduardo Valentin <eduardo.valentin@...com>
To: Dan Carpenter <dan.carpenter@...cle.com>
CC: <gregkh@...uxfoundation.org>, <devel@...verdev.osuosl.org>,
<linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-pm@...r.kernel.org>
Subject: Re: [PATCH 00/50] staging: omap-thermal: several code refactoring
Hello Dan,
On 16-03-2013 05:05, Dan Carpenter wrote:
> I've reviewed this set.
>
> I hate to make people redo whole patchset sets, and I hate
> re-reviewing code. Obviously, I don't really like the bunny hop
> patches and I'm trying to discourage that going forward. ;P But
> I wouldn't say it's a "Redo the whole thing" kind of problem.
>
> Could just resend patch 33 and 47? You should probably be able to
> redo those without changing the rest.
I could of course change them if the comment is better clarified. As I
mentioned as reply to one of your comments, those changes are following
what is suggested in CodingStyle file.
I can of course send a diff on top of 33, to fix the introduce bug.
For 47, I'm not sure the comment is fully applicable.
>
> regards,
> dan carpenter
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists