linux-kernel - Re: [PATCH 33/50] staging: omap-thermal: refactor APIs handling threshold values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130316135821.GJ9189@mwanda>
Date:	Sat, 16 Mar 2013 16:58:21 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Eduardo Valentin <eduardo.valentin@...com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org
Subject: Re: [PATCH 33/50] staging: omap-thermal: refactor APIs handling
 threshold values

On Sat, Mar 16, 2013 at 08:49:20AM -0400, Eduardo Valentin wrote:
> On 16-03-2013 04:39, Dan Carpenter wrote:
> >On Fri, Mar 15, 2013 at 09:00:21AM -0400, Eduardo Valentin wrote:
> >>  	if (ret) {
> >>  		dev_err(bg_ptr->dev, "failed to read thot\n");
> >>-		return -EIO;
> >>+		ret = -EIO;
> >>+		goto exit;
> >>  	}
> >>
> >>-	*thot = temp;
> >>+	*val = temp;
> >>
> >>+exit:
> >>  	return 0;
> >>  }
> >
> >
> >The bunny hop has introduced a bug and this always returns success.
> 
> What was the bug introduced?
> 
> I will send a patch to fix the return value.

Returning the wrong value *is* the bug.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/