linux-kernel - RAMster selects HAVE_ALIGNED_STRUCT_PAGE on 64 bit systems when it should not

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1577953.rJTZvHtihu@tacticalops>
Date:	Sat, 16 Mar 2013 20:35:59 +0100
From:	Martin Walch <walch.martin@....de>
To:	linux-kernel@...r.kernel.org
Subject: RAMster selects HAVE_ALIGNED_STRUCT_PAGE on 64 bit systems when it should not

At drivers/staging/zcache/Kconfig:13 it says

config RAMSTER
	bool "Cross-machine RAM capacity sharing, aka peer-to-peer tmem"
	depends on CONFIGFS_FS=y && SYSFS=y && !HIGHMEM && ZCACHE=y
	depends on NET
	# must ensure struct page is 8-byte aligned
	select HAVE_ALIGNED_STRUCT_PAGE if !64_BIT
	default n

However, there is no config section for the symbol 64_BIT, so !64_BIT will 
always be evaluated to true, and therefore RAMSTER will always select 
HAVE_ALIGNED_STRUCT_PAGE, disregarding any breakage.

64_BIT should probably say 64BIT which has corresponding config sections in 
arch/{x86,ia64,mips,s390,tile,alpha,arm64,sparc,parisc,powerpc}/Kconfig and 
arch/x86/um/Kconfig.

I do not know if there are any bad consequences about this, but I guess this 
should be reviewed and fixed, probably by just removing the underscore from 
64_BIT in drivers/staging/zcache/Kconfig.

Regards
Martin Walch
-- 

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)