linux-kernel - Re: CONFIG_EARLY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 16 Mar 2013 21:10:43 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Randy Dunlap <rdunlap@...radead.org>
Cc:	Thomas Meyer <thomas@...3r.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	x86@...nel.org
Subject: Re: CONFIG_EARLY_PRINTK

On Sat, Mar 16, 2013 at 6:38 PM, Randy Dunlap <rdunlap@...radead.org> wrote:
> On 03/16/13 08:08, Thomas Meyer wrote:
>> Am Mittwoch, den 13.03.2013, 12:56 -0700 schrieb Randy Dunlap:
>>> On 03/13/13 10:15, Thomas Meyer wrote:
>>>> help text says:
>>>> "You should normally N here, unless you want to debug such a crash.
>>>> (Depends on: EXPERT [=n])"
>>>>
>>>> How to normally N here?

>> so why not do this? As the text to EARLY_PRINTK explains?
>
> Yes, the default should match the help text.

So just remove the "default n" line, as "n" is the default.

> Acked-by: Randy Dunlap <rdunlap@...radead.org>
>
> Please resend your patch with Signed-off-by: line.
>
> Thanks.
>
>>
>> diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
>> index b322f12..d6c2d89 100644
>> --- a/arch/x86/Kconfig.debug
>> +++ b/arch/x86/Kconfig.debug
>> @@ -32,7 +32,7 @@ config X86_VERBOSE_BOOTUP
>>
>>  config EARLY_PRINTK
>>         bool "Early printk" if EXPERT
>> -       default y
>> +       default n
>>         ---help---
>>           Write kernel log output directly into the VGA buffer or to a
>> serial
>>           port.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/